Re: [PATCH v2] Arm: correct FIXADDR_TOP

2024-08-13 Thread Julien Grall
Hi, On 13/08/2024 12:57, Michal Orzel wrote: On 13/08/2024 13:49, Jan Beulich wrote: While reviewing a RISC-V patch cloning the Arm code, I noticed an off-by-1 here: FIX_PMAP_{BEGIN,END} being an inclusive range and FIX_LAST being the same as FIX_PMAP_END, FIXADDR_TOP cannot derive from FIX

Re: [PATCH v2] Arm: correct FIXADDR_TOP

2024-08-13 Thread Michal Orzel
On 13/08/2024 13:49, Jan Beulich wrote: > > > While reviewing a RISC-V patch cloning the Arm code, I noticed an > off-by-1 here: FIX_PMAP_{BEGIN,END} being an inclusive range and > FIX_LAST being the same as FIX_PMAP_END, FIXADDR_TOP cannot derive from > FIX_LAST alone, or else the BUG_ON() in

[PATCH v2] Arm: correct FIXADDR_TOP

2024-08-13 Thread Jan Beulich
While reviewing a RISC-V patch cloning the Arm code, I noticed an off-by-1 here: FIX_PMAP_{BEGIN,END} being an inclusive range and FIX_LAST being the same as FIX_PMAP_END, FIXADDR_TOP cannot derive from FIX_LAST alone, or else the BUG_ON() in virt_to_fix() would trigger if FIX_PMAP_END ended up bei