Re: [PATCH v10 2/9] x86emul: rework CMP and TEST emulation

2020-05-29 Thread Andrew Cooper
On 29/05/2020 14:41, Jan Beulich wrote: > On 29.05.2020 14:24, Andrew Cooper wrote: >> On 25/05/2020 15:26, Jan Beulich wrote: >>> Unlike similarly encoded insns these don't write their memory operands, >> "write to their". >> >>> and hence x86_is_mem_write() should return false for them. However,

Re: [PATCH v10 2/9] x86emul: rework CMP and TEST emulation

2020-05-29 Thread Jan Beulich
On 29.05.2020 14:24, Andrew Cooper wrote: > On 25/05/2020 15:26, Jan Beulich wrote: >> Unlike similarly encoded insns these don't write their memory operands, > > "write to their". > >> and hence x86_is_mem_write() should return false for them. However, >> rather than adding special logic there,

Re: [PATCH v10 2/9] x86emul: rework CMP and TEST emulation

2020-05-29 Thread Andrew Cooper
On 25/05/2020 15:26, Jan Beulich wrote: > Unlike similarly encoded insns these don't write their memory operands, "write to their". > and hence x86_is_mem_write() should return false for them. However, > rather than adding special logic there, rework how their emulation gets > done, by making dec

[PATCH v10 2/9] x86emul: rework CMP and TEST emulation

2020-05-25 Thread Jan Beulich
Unlike similarly encoded insns these don't write their memory operands, and hence x86_is_mem_write() should return false for them. However, rather than adding special logic there, rework how their emulation gets done, by making decoding attributes properly describe the r/o nature of their memory op