Re: [PATCH v10 03/17] vpci: use per-domain PCI lock to protect vpci structure

2023-11-28 Thread Volodymyr Babchuk
Hi Roger Thank you for the review. Roger Pau Monné writes: > On Thu, Oct 12, 2023 at 10:09:15PM +, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko >> >> Use a previously introduced per-domain read/write lock to check >> whether vpci is present, so we are sure there are no access

Re: [PATCH v10 03/17] vpci: use per-domain PCI lock to protect vpci structure

2023-11-17 Thread Roger Pau Monné
On Thu, Oct 12, 2023 at 10:09:15PM +, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Use a previously introduced per-domain read/write lock to check > whether vpci is present, so we are sure there are no accesses to the > contents of the vpci struct if not. This lock can be used

Re: [PATCH v10 03/17] vpci: use per-domain PCI lock to protect vpci structure

2023-11-03 Thread Stewart Hildebrand
On 10/12/23 18:09, Volodymyr Babchuk wrote: > 6. We are removing multiple ASSERT(pcidevs_locked()) instances because > they are too strict now: they should be corrected to > ASSERT(pcidevs_locked() || rw_is_locked(&d->pci_lock)), but problem is > that mentioned instances does not have access to the

[PATCH v10 03/17] vpci: use per-domain PCI lock to protect vpci structure

2023-10-12 Thread Volodymyr Babchuk
From: Oleksandr Andrushchenko Use a previously introduced per-domain read/write lock to check whether vpci is present, so we are sure there are no accesses to the contents of the vpci struct if not. This lock can be used (and in a few cases is used right away) so that vpci removal can be performe