Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-28 Thread Jan Beulich
On 28.10.2020 16:20, Rahul Singh wrote: >> On 28 Oct 2020, at 11:51 am, Jan Beulich wrote: >> On 26.10.2020 18:17, Rahul Singh wrote: >>> +int arch_pci_release_devices(struct domain *d) >>> +{ >>> +return pci_clean_dpci_irqs(d); >>> +} >> >> Why the extra function layer? > > Is that ok if I r

Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-28 Thread Rahul Singh
Hello Jan, > On 28 Oct 2020, at 11:51 am, Jan Beulich wrote: > > On 26.10.2020 18:17, Rahul Singh wrote: >> passthrough/pci.c file is common for all architecture, but there is x86 >> sepcific code in this file. > > The code you move doesn't look to be x86 specific in the sense that > it makes n

Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-28 Thread Julien Grall
On 28/10/2020 11:51, Jan Beulich wrote: On 26.10.2020 18:17, Rahul Singh wrote: passthrough/pci.c file is common for all architecture, but there is x86 sepcific code in this file. The code you move doesn't look to be x86 specific in the sense that it makes no sense on other architectures, b

Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-28 Thread Jan Beulich
On 26.10.2020 18:17, Rahul Singh wrote: > passthrough/pci.c file is common for all architecture, but there is x86 > sepcific code in this file. The code you move doesn't look to be x86 specific in the sense that it makes no sense on other architectures, but just because certain pieces are missing

Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-27 Thread Stefano Stabellini
On Mon, 26 Oct 2020, Rahul Singh wrote: > passthrough/pci.c file is common for all architecture, but there is x86 > sepcific code in this file. ^ specific > Move x86 specific code to the x86 directory to avoid compilation error > for other architecture. > > No functional change. > > Signed-off

[PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-26 Thread Rahul Singh
passthrough/pci.c file is common for all architecture, but there is x86 sepcific code in this file. Move x86 specific code to the x86 directory to avoid compilation error for other architecture. No functional change. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/pci.c| 75 +---