Re: [PATCH v1 1/3] xen/console: cleanup conring management

2025-04-28 Thread dmkhn
On Mon, Apr 28, 2025 at 08:47:01AM +0200, Jan Beulich wrote: > On 26.04.2025 00:18, Stefano Stabellini wrote: > > On Thu, 3 Apr 2025, dm...@proton.me wrote: > >> From: Denis Mukhin > >> > >> Move console_locks_busted handling inside conring_puts() to remove > >> tasklet code duplication. > >> > >>

Re: [PATCH v1 1/3] xen/console: cleanup conring management

2025-04-27 Thread Jan Beulich
On 26.04.2025 00:18, Stefano Stabellini wrote: > On Thu, 3 Apr 2025, dm...@proton.me wrote: >> From: Denis Mukhin >> >> Move console_locks_busted handling inside conring_puts() to remove >> tasklet code duplication. >> >> Signed-off-by: Denis Mukhin > > This patch is a good cleanup but makes one

Re: [PATCH v1 1/3] xen/console: cleanup conring management

2025-04-25 Thread Stefano Stabellini
On Thu, 3 Apr 2025, dm...@proton.me wrote: > From: Denis Mukhin > > Move console_locks_busted handling inside conring_puts() to remove > tasklet code duplication. > > Signed-off-by: Denis Mukhin This patch is a good cleanup but makes one functional change: previously guest_console_write would

Re: [PATCH v1 1/3] xen/console: cleanup conring management

2025-04-10 Thread Jan Beulich
On 03.04.2025 02:06, dm...@proton.me wrote: > From: Denis Mukhin > > Move console_locks_busted handling inside conring_puts() to remove > tasklet code duplication. I for one wouldn't expect tasklet scheduling to happen in a function of this name. IOW I think the little bit of duplication is warr

[PATCH v1 1/3] xen/console: cleanup conring management

2025-04-02 Thread dmkhn
From: Denis Mukhin Move console_locks_busted handling inside conring_puts() to remove tasklet code duplication. Signed-off-by: Denis Mukhin --- xen/drivers/char/console.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/xen/drivers/char/consol