Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Jan Beulich
On 03.02.2025 15:23, Andrew Cooper wrote: > On 03/02/2025 1:03 pm, Jan Beulich wrote: >> On 03.02.2025 14:00, Jan Beulich wrote: >>> On 03.02.2025 13:45, Roger Pau Monné wrote: On Thu, Jan 30, 2025 at 12:12:31PM +0100, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/mmconfig-shared.c >

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Andrew Cooper
On 03/02/2025 9:09 am, Jan Beulich wrote: > On 02.02.2025 15:46, Andrew Cooper wrote: >> On 30/01/2025 11:12 am, Jan Beulich wrote: >>> In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to >>> have permanent effect, pci_segments_init() needs to be called ahead of >>> making it ther

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Andrew Cooper
On 03/02/2025 1:03 pm, Jan Beulich wrote: > On 03.02.2025 14:00, Jan Beulich wrote: >> On 03.02.2025 13:45, Roger Pau Monné wrote: >>> On Thu, Jan 30, 2025 at 12:12:31PM +0100, Jan Beulich wrote: --- a/xen/arch/x86/x86_64/mmconfig-shared.c +++ b/xen/arch/x86/x86_64/mmconfig-shared.c

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Jan Beulich
On 03.02.2025 14:00, Jan Beulich wrote: > On 03.02.2025 13:45, Roger Pau Monné wrote: >> On Thu, Jan 30, 2025 at 12:12:31PM +0100, Jan Beulich wrote: >>> --- a/xen/arch/x86/x86_64/mmconfig-shared.c >>> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c >>> @@ -402,8 +402,6 @@ void __init acpi_mmcfg_init(v

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Jan Beulich
On 03.02.2025 13:45, Roger Pau Monné wrote: > On Thu, Jan 30, 2025 at 12:12:31PM +0100, Jan Beulich wrote: >> In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to >> have permanent effect, pci_segments_init() needs to be called ahead of >> making it there. Without this we're losing

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Roger Pau Monné
On Thu, Jan 30, 2025 at 12:12:31PM +0100, Jan Beulich wrote: > In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to > have permanent effect, pci_segments_init() needs to be called ahead of > making it there. Without this we're losing segment 0's r/o map, and thus > we're losing wri

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-03 Thread Jan Beulich
On 02.02.2025 15:46, Andrew Cooper wrote: > On 30/01/2025 11:12 am, Jan Beulich wrote: >> In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to >> have permanent effect, pci_segments_init() needs to be called ahead of >> making it there. Without this we're losing segment 0's r/o map

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-02-02 Thread Andrew Cooper
On 30/01/2025 11:12 am, Jan Beulich wrote: > In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to > have permanent effect, pci_segments_init() needs to be called ahead of > making it there. Without this we're losing segment 0's r/o map, and thus > we're losing write-protection of t

Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-01-31 Thread Jason Andryuk
On 2025-01-30 06:12, Jan Beulich wrote: In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to have permanent effect, pci_segments_init() needs to be called ahead of making it there. Without this we're losing segment 0's r/o map, and thus we're losing write-protection of the PCI de

[PATCH for-4.20 2/3] x86/PCI: init segments earlier

2025-01-30 Thread Jan Beulich
In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to have permanent effect, pci_segments_init() needs to be called ahead of making it there. Without this we're losing segment 0's r/o map, and thus we're losing write-protection of the PCI devices representing IOMMUs. Which in turn m