Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-02-03 Thread Oleksii Kurochko
inal Message- From: Andrew Cooper Sent: Monday, January 27, 2025 6:42 AM To: Oleksii Kurochko ; Xen-devel Cc: Katz, Jonathan ; Jan Beulich ; Roger Pau Monné Subject: Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised EXTERNAL MAIL: Do not click any links or open any

RE: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-27 Thread Katz, Jonathan
n.k...@aptar.com> | www.aptar.com<http://www.aptar.com/> AptarOnlineSignature -Original Message- From: Andrew Cooper Sent: Monday, January 27, 2025 6:42 AM To: Oleksii Kurochko ; Xen-devel Cc: Katz, Jonathan ; Jan Beulich ; Roger Pau Monné Subject: Re: [PATCH for-4.20] x8

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-27 Thread Andrew Cooper
On 21/01/2025 4:57 pm, Oleksii Kurochko wrote: > > On 1/21/25 3:25 PM, Andrew Cooper wrote: >> Logic using performance counters needs to look at >> MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. >> >> When virtualised under ESX, Xen dies with a #GP fault trying to read >> MSR_C

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Oleksii Kurochko
On 1/21/25 3:25 PM, Andrew Cooper wrote: Logic using performance counters needs to look at MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. When virtualised under ESX, Xen dies with a #GP fault trying to read MSR_CORE_PERF_GLOBAL_CTRL. Factor this logic out into a separate

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Roger Pau Monné
On Tue, Jan 21, 2025 at 02:25:10PM +, Andrew Cooper wrote: > Logic using performance counters needs to look at > MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. > > When virtualised under ESX, Xen dies with a #GP fault trying to read > MSR_CORE_PERF_GLOBAL_CTRL. > > Factor

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Andrew Cooper
On 21/01/2025 3:58 pm, Jan Beulich wrote: > On 21.01.2025 16:23, Andrew Cooper wrote: >> On 21/01/2025 3:03 pm, Jan Beulich wrote: >>> On 21.01.2025 15:25, Andrew Cooper wrote: + !(val & MSR_IA32_MISC_ENABLE_PERF_AVAIL) ) +return; + +eax = cpuid_eax(10);

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Jan Beulich
On 21.01.2025 16:23, Andrew Cooper wrote: > On 21/01/2025 3:03 pm, Jan Beulich wrote: >> On 21.01.2025 15:25, Andrew Cooper wrote: >>> Logic using performance counters needs to look at >>> MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. >>> >>> When virtualised under ESX, Xen di

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Andrew Cooper
On 21/01/2025 3:03 pm, Jan Beulich wrote: > On 21.01.2025 15:25, Andrew Cooper wrote: >> Logic using performance counters needs to look at >> MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. >> >> When virtualised under ESX, Xen dies with a #GP fault trying to read >> MSR_CORE_PE

Re: [PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Jan Beulich
On 21.01.2025 15:25, Andrew Cooper wrote: > Logic using performance counters needs to look at > MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. > > When virtualised under ESX, Xen dies with a #GP fault trying to read > MSR_CORE_PERF_GLOBAL_CTRL. > > Factor this logic out into

[PATCH for-4.20] x86/intel: Fix PERF_GLOBAL fixup when virtualised

2025-01-21 Thread Andrew Cooper
Logic using performance counters needs to look at MSR_MISC_ENABLE.PERF_AVAILABLE before touching any other resources. When virtualised under ESX, Xen dies with a #GP fault trying to read MSR_CORE_PERF_GLOBAL_CTRL. Factor this logic out into a separate function (it's already too squashed to the RH