Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-24 Thread oleksii . kurochko
On Wed, 2024-07-24 at 11:50 +, Anthony PERARD wrote: > On Tue, Jul 23, 2024 at 07:31:58PM +0200, > oleksii.kuroc...@gmail.com wrote: > > On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: > > > Oleksii, this is a fix (for an incomplete fix) for 4.19.  > > > 76a484193d > > > broke compatib

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-24 Thread Jason Andryuk
On 2024-07-24 08:41, Jan Beulich wrote: On 23.07.2024 17:04, Anthony PERARD wrote: On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly for backendtype=phy as well as backendtype=tap. Move the setting into the conditional, so it can be handled properl

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-24 Thread Jan Beulich
On 23.07.2024 17:04, Anthony PERARD wrote: > On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: >> "$dev" needs to be set correctly for backendtype=phy as well as >> backendtype=tap. Move the setting into the conditional, so it can be >> handled properly for each. >> >> (dev could be c

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-24 Thread Anthony PERARD
On Tue, Jul 23, 2024 at 07:31:58PM +0200, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: > > Oleksii, this is a fix (for an incomplete fix) for 4.19.  76a484193d > > broke compatibility for block-tap with the blktap2 kernel model (when > > adding support

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-24 Thread oleksii . kurochko
On Tue, 2024-07-23 at 14:05 -0400, Jason Andryuk wrote: > On 2024-07-23 13:34, Andrew Cooper wrote: > > On 23/07/2024 6:31 pm, oleksii.kuroc...@gmail.com wrote: > > > On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: > > > > On 2024-07-23 11:04, Anthony PERARD wrote: > > > > > On Mon, Jul 15,

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Jason Andryuk
On 2024-07-23 13:34, Andrew Cooper wrote: On 23/07/2024 6:31 pm, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: On 2024-07-23 11:04, Anthony PERARD wrote: On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Andrew Cooper
On 23/07/2024 6:31 pm, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: >> On 2024-07-23 11:04, Anthony PERARD wrote: >>> On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly for backendtype=phy as well as >>

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: > On 2024-07-23 11:04, Anthony PERARD wrote: > > On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: > > > "$dev" needs to be set correctly for backendtype=phy as well as > > > backendtype=tap.  Move the setting into the conditional

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Jason Andryuk
On 2024-07-23 11:04, Anthony PERARD wrote: On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly for backendtype=phy as well as backendtype=tap. Move the setting into the conditional, so it can be handled properly for each. (dev could be captured durin

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Anthony PERARD
On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: > "$dev" needs to be set correctly for backendtype=phy as well as > backendtype=tap. Move the setting into the conditional, so it can be > handled properly for each. > > (dev could be captured during tap-ctl allocate for blktap module

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-15 Thread Jan Beulich
On 16.07.2024 01:46, Jason Andryuk wrote: > From: Jason Andryuk > > "$dev" needs to be set correctly for backendtype=phy as well as > backendtype=tap. Move the setting into the conditional, so it can be > handled properly for each. > > (dev could be captured during tap-ctl allocate for blktap m

[PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-15 Thread Jason Andryuk
From: Jason Andryuk "$dev" needs to be set correctly for backendtype=phy as well as backendtype=tap. Move the setting into the conditional, so it can be handled properly for each. (dev could be captured during tap-ctl allocate for blktap module, but it would not be set properly for the find_dev

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility

2024-06-20 Thread Oleksii K.
On Wed, 2024-06-19 at 14:33 +, Anthony PERARD wrote: > On Wed, Jun 19, 2024 at 02:07:04PM +0200, Jan Beulich wrote: > > On 16.05.2024 15:52, Jason Andryuk wrote: > > > On 2024-05-16 03:41, Jan Beulich wrote: > > > > On 16.05.2024 04:22, Jason Andryuk wrote: > > > > > From: Jason Andryuk > > >

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility

2024-06-19 Thread Anthony PERARD
On Wed, Jun 19, 2024 at 02:07:04PM +0200, Jan Beulich wrote: > On 16.05.2024 15:52, Jason Andryuk wrote: > > On 2024-05-16 03:41, Jan Beulich wrote: > >> On 16.05.2024 04:22, Jason Andryuk wrote: > >>> From: Jason Andryuk > >>> > >>> From: Jason Andryuk > >> > >> Two identical From: (also in anot

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility

2024-06-19 Thread Jan Beulich
On 16.05.2024 15:52, Jason Andryuk wrote: > On 2024-05-16 03:41, Jan Beulich wrote: >> On 16.05.2024 04:22, Jason Andryuk wrote: >>> From: Jason Andryuk >>> >>> From: Jason Andryuk >> >> Two identical From: (also in another patch of yours, while in yet another one >> you have two _different_ ones