Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-14 Thread Roger Pau Monné
On Mon, Nov 14, 2022 at 03:31:39PM +, Andrew Cooper wrote: > On 14/11/2022 13:15, Roger Pau Monne wrote: > > On Fri, Nov 11, 2022 at 05:47:02PM +, Andrew Cooper wrote: > >> On 11/11/2022 17:35, Andrew Cooper wrote: > >>> On 11/11/2022 07:45, Jan Beulich wrote: > On 10.11.2022 23:47, An

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-14 Thread Andrew Cooper
On 14/11/2022 13:15, Roger Pau Monne wrote: > On Fri, Nov 11, 2022 at 05:47:02PM +, Andrew Cooper wrote: >> On 11/11/2022 17:35, Andrew Cooper wrote: >>> On 11/11/2022 07:45, Jan Beulich wrote: On 10.11.2022 23:47, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote:

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-14 Thread Roger Pau Monné
On Fri, Nov 11, 2022 at 05:47:02PM +, Andrew Cooper wrote: > On 11/11/2022 17:35, Andrew Cooper wrote: > > On 11/11/2022 07:45, Jan Beulich wrote: > >> On 10.11.2022 23:47, Andrew Cooper wrote: > >>> On 04/11/2022 16:18, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/viridian/viridian.c >

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-14 Thread Roger Pau Monné
On Thu, Nov 10, 2022 at 10:47:07PM +, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote: > > The current reporting of the hardware assisted APIC options is done by > > checking "virtualize APIC accesses" which is not very helpful, as that > > feature doesn't avoid a vmexit, inst

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-13 Thread Jan Beulich
On 11.11.2022 18:35, Andrew Cooper wrote: > On 11/11/2022 07:45, Jan Beulich wrote: >> On 10.11.2022 23:47, Andrew Cooper wrote: >>> On 04/11/2022 16:18, Roger Pau Monne wrote: --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -197,7 +197,7 @@ v

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-11 Thread Andrew Cooper
On 11/11/2022 17:35, Andrew Cooper wrote: > On 11/11/2022 07:45, Jan Beulich wrote: >> On 10.11.2022 23:47, Andrew Cooper wrote: >>> On 04/11/2022 16:18, Roger Pau Monne wrote: --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -197,7 +197,7 @@ v

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-11 Thread Andrew Cooper
On 11/11/2022 07:45, Jan Beulich wrote: > On 10.11.2022 23:47, Andrew Cooper wrote: >> On 04/11/2022 16:18, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/viridian/viridian.c >>> +++ b/xen/arch/x86/hvm/viridian/viridian.c >>> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v,

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-11 Thread Roger Pau Monné
On Thu, Nov 10, 2022 at 10:47:07PM +, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote: > > The current reporting of the hardware assisted APIC options is done by > > checking "virtualize APIC accesses" which is not very helpful, as that > > feature doesn't avoid a vmexit, inst

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-10 Thread Jan Beulich
On 10.11.2022 23:47, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote: >> --- a/xen/arch/x86/hvm/viridian/viridian.c >> +++ b/xen/arch/x86/hvm/viridian/viridian.c >> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, >> uint32_t leaf, >> res->a = CPUID4A

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-10 Thread Andrew Cooper
On 04/11/2022 16:18, Roger Pau Monne wrote: > The current reporting of the hardware assisted APIC options is done by > checking "virtualize APIC accesses" which is not very helpful, as that > feature doesn't avoid a vmexit, instead it does provide some help in > order to detect APIC MMIO accesses i

RE: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-09 Thread Henry Wang
Hi Andrew, > Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the > APIC assist options > > > Everything else looks plausible to me, but from prior discussion I > wonder whether the result isn't still going to be too coarse grained > for Andrew&

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-08 Thread Roger Pau Monné
On Mon, Nov 07, 2022 at 05:58:04PM +0100, Jan Beulich wrote: > On 04.11.2022 17:18, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, > > uint32_t leaf, > >

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-07 Thread Jan Beulich
On 04.11.2022 17:18, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t > leaf, > res->a = CPUID4A_RELAX_TIMER_INT; > if ( viridian_featur

RE: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Henry Wang
Hi Roger, > Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the > APIC assist options > > On 04/11/2022 16:18, Roger Pau Monne wrote: > > The current reporting of the hardware assisted APIC options is done by > > checking "virtualize APIC access

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Paul Durrant
On 04/11/2022 16:18, Roger Pau Monne wrote: The current reporting of the hardware assisted APIC options is done by checking "virtualize APIC accesses" which is not very helpful, as that feature doesn't avoid a vmexit, instead it does provide some help in order to detect APIC MMIO accesses in vmex

[PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-04 Thread Roger Pau Monne
The current reporting of the hardware assisted APIC options is done by checking "virtualize APIC accesses" which is not very helpful, as that feature doesn't avoid a vmexit, instead it does provide some help in order to detect APIC MMIO accesses in vmexit processing. Repurpose the current reportin