Re: [PATCH for-4.17 0/2] Ocaml stub fixes

2022-10-13 Thread Christian Lindig
This is a good use of the OCaml type system to ensure only compatible flags are shared in a list and not mixed between architectures. The macro changes are good housekeeping. — C Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>> On 12 Oct 2022, at 19:25, Andrew Cooper mailto:a

[PATCH for-4.17 0/2] Ocaml stub fixes

2022-10-12 Thread Andrew Cooper
Patch 1 is purely some a tweak to improve legibility. It's not necessary for 4.17 but it's also 0 risk to take as well. Patch 2 is a change to an ABI which was newly introduced in 4.17. It is suboptimal for two reasons and specifically does want changing before 4.17 ships. See patch for details