Re: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-31 Thread Julien Grall
On 18/08/2022 15:06, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 16 Aug 2022, at 19:59, Julien Grall wrote: From: Julien Grall __ro_after_init was introduced recently to prevent modifying some variables after init. At the moment, on Arm, the variables will still be accessible

Re: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-31 Thread Julien Grall
; Volodymyr Babchuk Subject: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm From: Julien Grall __ro_after_init was introduced recently to prevent modifying some variables after init. At the moment, on Arm, the variables will still be accessible because the region permission is not

Re: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-18 Thread Bertrand Marquis
Hi, > On 17 Aug 2022, at 10:14, Julien Grall wrote: > > Hi Jan, > > On 17/08/2022 09:37, Jan Beulich wrote: >> On 16.08.2022 20:59, Julien Grall wrote: >>> --- a/xen/arch/arm/setup.c >>> +++ b/xen/arch/arm/setup.c >>> @@ -75,10 +75,24 @@ domid_t __read_mostly max_init_domid; >>>static __use

Re: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-18 Thread Bertrand Marquis
Hi Julien, > On 16 Aug 2022, at 19:59, Julien Grall wrote: > > From: Julien Grall > > __ro_after_init was introduced recently to prevent modifying > some variables after init. > > At the moment, on Arm, the variables will still be accessible > because the region permission is not updated. >

Re: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-17 Thread Julien Grall
Hi Jan, On 17/08/2022 09:37, Jan Beulich wrote: On 16.08.2022 20:59, Julien Grall wrote: --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -75,10 +75,24 @@ domid_t __read_mostly max_init_domid; static __used void init_done(void) { +int rc; + /* Must be done past setting

Re: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-17 Thread Jan Beulich
On 16.08.2022 20:59, Julien Grall wrote: > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -75,10 +75,24 @@ domid_t __read_mostly max_init_domid; > > static __used void init_done(void) > { > +int rc; > + > /* Must be done past setting system_state. */ > unregister_ini

RE: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-16 Thread Penny Zheng
bject: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm > > From: Julien Grall > > __ro_after_init was introduced recently to prevent modifying some variables > after init. > > At the moment, on Arm, the variables will still be accessible because the >

RE: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-16 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: [PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm > > From: Julien Grall > > __ro_after_init was introduced recently to prevent modifying > some variables after init. > > At the moment, on Arm,

[PATCH for-4.17] xen/arm: Support properly __ro_after_init on Arm

2022-08-16 Thread Julien Grall
From: Julien Grall __ro_after_init was introduced recently to prevent modifying some variables after init. At the moment, on Arm, the variables will still be accessible because the region permission is not updated. Address that, but moving the sections .data.ro_after_init out of .data and then