Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-18 Thread Jan Beulich
On 18.11.2021 10:34, Roger Pau Monné wrote: > On Thu, Nov 18, 2021 at 09:51:52AM +0100, Jan Beulich wrote: >> On 18.11.2021 09:33, Roger Pau Monné wrote: >>> On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote: On 04.11.2021 11:48, Andrew Cooper wrote: > If your answer is "well act

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-18 Thread Roger Pau Monné
On Thu, Nov 18, 2021 at 09:51:52AM +0100, Jan Beulich wrote: > On 18.11.2021 09:33, Roger Pau Monné wrote: > > On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote: > >> On 04.11.2021 11:48, Andrew Cooper wrote: > >>> If your answer is "well actually, we didn't mean to say 'if a GSI is > >>>

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-18 Thread Jan Beulich
On 18.11.2021 09:33, Roger Pau Monné wrote: > On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote: >> On 04.11.2021 11:48, Andrew Cooper wrote: >>> If your answer is "well actually, we didn't mean to say 'if a GSI is >>> mapped' in the comment, and here's a different predicate which actuall

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-18 Thread Roger Pau Monné
On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote: > On 04.11.2021 11:48, Andrew Cooper wrote: > > If your answer is "well actually, we didn't mean to say 'if a GSI is > > mapped' in the comment, and here's a different predicate which actually > > inspects the state of a dpci object for v

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Jan Beulich
On 04.11.2021 16:24, Roger Pau Monné wrote: > It might be appropriate to switch pirq_dpci to: > > #define pirq_dpci(d, pirq) \ > ((is_hvm_domain(d) && (pirq)) ? &(pirq)->arch.hvm.dpci : NULL) I don't see how this would help suppress the warning. > Or to an inline helper. I expect it's a mac

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12"): > I honestly don't think we expect any property of pirq_dpci, it just > tells whether a pirq has a dpci associated with it or not. As I said > on my previous replies I thi

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Roger Pau Monné
On Thu, Nov 04, 2021 at 01:17:53PM +0100, Jan Beulich wrote: > On 04.11.2021 11:48, Andrew Cooper wrote: > > On 04/11/2021 08:07, Jan Beulich wrote: > >> On 03.11.2021 17:13, Ian Jackson wrote: > >>> Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build > >>> with GCC 12"): > >

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Jan Beulich
On 04.11.2021 11:48, Andrew Cooper wrote: > On 04/11/2021 08:07, Jan Beulich wrote: >> On 03.11.2021 17:13, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build >>> with GCC 12"): On 27.10.2021 22:07, Andrew Cooper wrote: > if ( !((pirq) ? &(p

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Andrew Cooper
On 04/11/2021 08:07, Jan Beulich wrote: > On 03.11.2021 17:13, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build >> with GCC 12"): >>> On 27.10.2021 22:07, Andrew Cooper wrote: if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) ) >>> I disagree with

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-04 Thread Jan Beulich
On 03.11.2021 17:13, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build > with GCC 12"): >> On 27.10.2021 22:07, Andrew Cooper wrote: >>> if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) ) >> >> I disagree with the compiler's analysis: While &(pirq)->arc

Re: [PATCH for-4.16] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12

2021-11-03 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] x86/passthrough: Fix hvm_gsi_eoi() build with GCC 12"): > On 27.10.2021 22:07, Andrew Cooper wrote: > > if ( !((pirq) ? &(pirq)->arch.hvm.dpci : NULL) ) > > I disagree with the compiler's analysis: While &(pirq)->arch.hvm.dpci > indeed can't be NULL, that's not