Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Jan Beulich
On 26.06.2020 17:03, Roger Pau Monné wrote: > On Fri, Jun 26, 2020 at 04:19:36PM +0200, Jan Beulich wrote: >> On 26.06.2020 15:40, Jan Beulich wrote: >>> On 25.06.2020 18:10, Roger Pau Monné wrote: On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: > On Wed, Jun 24, 2020 at 0

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Roger Pau Monné
On Fri, Jun 26, 2020 at 04:19:36PM +0200, Jan Beulich wrote: > On 26.06.2020 15:40, Jan Beulich wrote: > > On 25.06.2020 18:10, Roger Pau Monné wrote: > >> On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: > >>> On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Jan Beulich
On 26.06.2020 15:40, Jan Beulich wrote: > On 25.06.2020 18:10, Roger Pau Monné wrote: >> On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: >>> On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: On 24.06.2020 15:41, Julien Grall wrote: > On 24/06/2020 11:12, Jan Beu

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Jan Beulich
On 25.06.2020 18:10, Roger Pau Monné wrote: > On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: >> On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: >>> On 24.06.2020 15:41, Julien Grall wrote: On 24/06/2020 11:12, Jan Beulich wrote: > On 23.06.2020 19:26, Roger P

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-25 Thread Roger Pau Monné
On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: > On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: > > On 24.06.2020 15:41, Julien Grall wrote: > > > On 24/06/2020 11:12, Jan Beulich wrote: > > >> On 23.06.2020 19:26, Roger Pau Monné wrote: > > >>> I'm confused. Couldn'

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-25 Thread Julien Grall
Hi Jan, On 24/06/2020 15:01, Jan Beulich wrote: On 24.06.2020 15:41, Julien Grall wrote: On 24/06/2020 11:12, Jan Beulich wrote: On 23.06.2020 19:26, Roger Pau Monné wrote: I'm confused. Couldn't we switch from uint64_aligned_t to plain uint64_t (like it's currently on the Linux headers), and

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-25 Thread Roger Pau Monné
On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: > On 24.06.2020 15:41, Julien Grall wrote: > > On 24/06/2020 11:12, Jan Beulich wrote: > >> On 23.06.2020 19:26, Roger Pau Monné wrote: > >>> I'm confused. Couldn't we switch from uint64_aligned_t to plain > >>> uint64_t (like it's curren

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Jan Beulich
On 24.06.2020 15:41, Julien Grall wrote: > On 24/06/2020 11:12, Jan Beulich wrote: >> On 23.06.2020 19:26, Roger Pau Monné wrote: >>> I'm confused. Couldn't we switch from uint64_aligned_t to plain >>> uint64_t (like it's currently on the Linux headers), and then use the >>> compat layer in Xen to

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Julien Grall
Hi Jan, On 24/06/2020 11:12, Jan Beulich wrote: On 23.06.2020 19:26, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 06:18:52PM +0200, Jan Beulich wrote: On 23.06.2020 17:56, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 05:02:04PM +0200, Jan Beulich wrote: On 23.06.2020 15:52, Roger Pau Mon

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Jan Beulich
>> ; Ian Jackson >> ; Stefano Stabellini ; >> Wei Liu >> Subject: Re: [PATCH for-4.14] mm: fix public declaration of struct >> xen_mem_acquire_resource >> >> On 24.06.2020 14:47, Julien Grall wrote: >>> Hi, >>> >>> On 24/06/2020 13:

RE: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 24 June 2020 13:52 > To: Julien Grall > Cc: Roger Pau Monné ; xen-devel@lists.xenproject.org; > p...@xen.org; Andrew > Cooper ; George Dunlap ; > Ian Jackson > ; Stefano Stabellini ; Wei > Liu > Subj

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Jan Beulich
On 24.06.2020 14:47, Julien Grall wrote: > Hi, > > On 24/06/2020 13:08, Jan Beulich wrote: >> On 24.06.2020 12:52, Julien Grall wrote: >>> Hi Jan, >>> >>> On 24/06/2020 11:05, Jan Beulich wrote: On 23.06.2020 19:32, Roger Pau Monné wrote: > On Tue, Jun 23, 2020 at 05:04:53PM +0200, Jan Be

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Julien Grall
Hi, On 24/06/2020 13:08, Jan Beulich wrote: On 24.06.2020 12:52, Julien Grall wrote: Hi Jan, On 24/06/2020 11:05, Jan Beulich wrote: On 23.06.2020 19:32, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 05:04:53PM +0200, Jan Beulich wrote: On 23.06.2020 15:52, Roger Pau Monne wrote: XENMEM_a

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Jan Beulich
On 24.06.2020 12:52, Julien Grall wrote: > Hi Jan, > > On 24/06/2020 11:05, Jan Beulich wrote: >> On 23.06.2020 19:32, Roger Pau Monné wrote: >>> On Tue, Jun 23, 2020 at 05:04:53PM +0200, Jan Beulich wrote: On 23.06.2020 15:52, Roger Pau Monne wrote: > XENMEM_acquire_resource and it's rel

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Julien Grall
Hi Jan, On 24/06/2020 11:05, Jan Beulich wrote: On 23.06.2020 19:32, Roger Pau Monné wrote: On Tue, Jun 23, 2020 at 05:04:53PM +0200, Jan Beulich wrote: On 23.06.2020 15:52, Roger Pau Monne wrote: XENMEM_acquire_resource and it's related structure is currently inside a __XEN__ or __XEN_TOOLS_

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Jan Beulich
On 23.06.2020 19:26, Roger Pau Monné wrote: > On Tue, Jun 23, 2020 at 06:18:52PM +0200, Jan Beulich wrote: >> On 23.06.2020 17:56, Roger Pau Monné wrote: >>> On Tue, Jun 23, 2020 at 05:02:04PM +0200, Jan Beulich wrote: On 23.06.2020 15:52, Roger Pau Monne wrote: > XENMEM_acquire_resource a

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-24 Thread Jan Beulich
On 23.06.2020 19:32, Roger Pau Monné wrote: > On Tue, Jun 23, 2020 at 05:04:53PM +0200, Jan Beulich wrote: >> On 23.06.2020 15:52, Roger Pau Monne wrote: >>> XENMEM_acquire_resource and it's related structure is currently inside >>> a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 05:04:53PM +0200, Jan Beulich wrote: > On 23.06.2020 15:52, Roger Pau Monne wrote: > > XENMEM_acquire_resource and it's related structure is currently inside > > a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the > > hypervisor or the toolstack only. This

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 06:18:52PM +0200, Jan Beulich wrote: > On 23.06.2020 17:56, Roger Pau Monné wrote: > > On Tue, Jun 23, 2020 at 05:02:04PM +0200, Jan Beulich wrote: > >> On 23.06.2020 15:52, Roger Pau Monne wrote: > >>> XENMEM_acquire_resource and it's related structure is currently inside >

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Jan Beulich
On 23.06.2020 17:56, Roger Pau Monné wrote: > On Tue, Jun 23, 2020 at 05:02:04PM +0200, Jan Beulich wrote: >> On 23.06.2020 15:52, Roger Pau Monne wrote: >>> XENMEM_acquire_resource and it's related structure is currently inside >>> a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 05:02:04PM +0200, Jan Beulich wrote: > On 23.06.2020 15:52, Roger Pau Monne wrote: > > XENMEM_acquire_resource and it's related structure is currently inside > > a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the > > hypervisor or the toolstack only. This

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Jan Beulich
On 23.06.2020 15:52, Roger Pau Monne wrote: > XENMEM_acquire_resource and it's related structure is currently inside > a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the > hypervisor or the toolstack only. This is wrong as the hypercall is > already being used by the Linux kernel

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Jan Beulich
On 23.06.2020 15:52, Roger Pau Monne wrote: > XENMEM_acquire_resource and it's related structure is currently inside > a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the > hypervisor or the toolstack only. This is wrong as the hypercall is > already being used by the Linux kernel

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Julien Grall
On 23/06/2020 14:52, Roger Pau Monne wrote: XENMEM_acquire_resource and it's related structure is currently inside a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the hypervisor or the toolstack only. This is wrong as the hypercall is already being used by the Linux kernel at

RE: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Paul Durrant
i > Liu > Subject: [PATCH for-4.14] mm: fix public declaration of struct > xen_mem_acquire_resource > > XENMEM_acquire_resource and it's related structure is currently inside > a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the > hypervisor or th

[PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-23 Thread Roger Pau Monne
XENMEM_acquire_resource and it's related structure is currently inside a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the hypervisor or the toolstack only. This is wrong as the hypercall is already being used by the Linux kernel at least, and as such needs to be public. Also swi