Re: [PATCH for-4.14] golang/xenlight: sort cases in switch statement

2020-06-15 Thread George Dunlap
> On Jun 15, 2020, at 4:43 PM, Ian Jackson wrote: > > Nick Rosbrook writes ("[PATCH for-4.14] golang/xenlight: sort cases in switch > statement"): >> The xenlight_golang_union_from_C function iterates over a dict to >> construct a switch statement that

RE: [PATCH for-4.14] golang/xenlight: sort cases in switch statement

2020-06-15 Thread Paul Durrant
> -Original Message- > From: Ian Jackson > Sent: 15 June 2020 16:43 > To: Nick Rosbrook > Cc: xen-devel@lists.xenproject.org; p...@xen.org; Andrew Cooper > ; Nick > Rosbrook ; George Dunlap ; > Wei Liu > Subject: Re: [PATCH for-4.14] golang/xenlight: sor

Re: [PATCH for-4.14] golang/xenlight: sort cases in switch statement

2020-06-15 Thread Ian Jackson
Nick Rosbrook writes ("[PATCH for-4.14] golang/xenlight: sort cases in switch statement"): > The xenlight_golang_union_from_C function iterates over a dict to > construct a switch statement that marshals a C keyed union into a Go > type. Because python does not guarantee dict

[PATCH for-4.14] golang/xenlight: sort cases in switch statement

2020-06-15 Thread Nick Rosbrook
The xenlight_golang_union_from_C function iterates over a dict to construct a switch statement that marshals a C keyed union into a Go type. Because python does not guarantee dict ordering across all versions, this can result in the switch statement being generated in a different order depending on