Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-09 Thread Anthony PERARD
Sorry, I've replied to the wrong version, but those comment apply to V7. Cheers, -- Anthony PERARD

Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-09 Thread Anthony PERARD
On Tue, Nov 08, 2022 at 04:53:59PM +0530, Viresh Kumar wrote: > diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py > index 7bf26bdcd831..b188104299b1 100644 > --- a/tools/ocaml/libs/xl/genwrap.py > +++ b/tools/ocaml/libs/xl/genwrap.py > @@ -36,6 +36,7 @@ DEVICE_LIST =

Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-06 Thread Oleksandr Tyshchenko
On 05.12.22 08:20, Viresh Kumar wrote: Hello Viresh On 02-12-22, 19:16, Oleksandr Tyshchenko wrote: Interesting, I see you allow user to configure virtio-mmio params (irq and base), as far as I remember for virtio-disk these are internal only (allocated by tools/libs/light/libxl_arm.c). I

Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-04 Thread Viresh Kumar
On 02-12-22, 19:16, Oleksandr Tyshchenko wrote: > Interesting, I see you allow user to configure virtio-mmio params (irq and > base), as far as I remember for virtio-disk these are internal only > (allocated by tools/libs/light/libxl_arm.c). It is a mistake. Will drop it. -- viresh

Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-02 Thread Oleksandr Tyshchenko
On 08.11.22 13:23, Viresh Kumar wrote: Hello Viresh [sorry for the possible format issues if any] This patch adds basic support for parsing generic Virtio backend. An example of domain configuration for mmio based Virtio I2C device is: virtio = ["type=virtio,device22,transport=mmio"] Sig

[PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-11-08 Thread Viresh Kumar
This patch adds basic support for parsing generic Virtio backend. An example of domain configuration for mmio based Virtio I2C device is: virtio = ["type=virtio,device22,transport=mmio"] Signed-off-by: Viresh Kumar --- tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_st