Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-08 Thread Anthony PERARD
On Wed, Sep 07, 2022 at 06:02:24PM +0530, Viresh Kumar wrote: > Hi Anthony, > > Thanks a lot for the in-depth review, it is really helpful. > > I don't have much knowledge of the Xen code and wanted this code for I2C and > GPIO to be tested on Xen for the work we are doing around hypervisor agnos

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-07 Thread Juergen Gross
On 08.09.22 06:24, Viresh Kumar wrote: On 07-09-22, 18:49, Julien Grall wrote: Looking at this series, you will add ~250 lines (assuming your new patch) for the i2c and then likely the same amount for GPIO. I am assuming that for every new virtio device (e.g. gps, sound, display...), we would a

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-07 Thread Viresh Kumar
On 07-09-22, 18:49, Julien Grall wrote: > Looking at this series, you will add ~250 lines (assuming your new patch) > for the i2c and then likely the same amount for GPIO. > > I am assuming that for every new virtio device (e.g. gps, sound, > display...), we would also need to 250 lines of code. I

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-07 Thread Julien Grall
Hi Viresh, Jumping in the conversation. On 07/09/2022 13:32, Viresh Kumar wrote: I don't have much knowledge of the Xen code and wanted this code for I2C and GPIO to be tested on Xen for the work we are doing around hypervisor agnostic backends [1]. I started looking for a simple device's impl

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-07 Thread Viresh Kumar
Hi Anthony, Thanks a lot for the in-depth review, it is really helpful. I don't have much knowledge of the Xen code and wanted this code for I2C and GPIO to be tested on Xen for the work we are doing around hypervisor agnostic backends [1]. I started looking for a simple device's implementation

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-06 Thread Anthony PERARD
Hi Viresh, On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote: > This patch adds basic support for configuring and assisting virtio-mmio > based virtio-i2c backend (emualator) which is intended to run out of > Qemu and could be run in any domain. "to run out of Qemu" -> this is ambiguou

[PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-08-22 Thread Viresh Kumar
This patch adds basic support for configuring and assisting virtio-mmio based virtio-i2c backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio I2c: i2c = [ "" ] Please note, this patch is not enough for virtio-i2c to