Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
On 01/12/2020 12:24, Oleksandr wrote: On 01.12.20 14:13, Julien Grall wrote: Hi Oleksandr, Hi Julien. --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const struct cpu_user_regs *regs)    (unsigned

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Oleksandr
On 01.12.20 14:13, Julien Grall wrote: Hi Oleksandr, Hi Julien. --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const struct cpu_user_regs *regs)    (unsigned long)abort_guest_exit_end == regs->pc;   

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
Hi Oleksandr, On 01/12/2020 10:42, Oleksandr wrote: On 01.12.20 12:30, Julien Grall wrote: Hi Julien Hi Jan, On 01/12/2020 07:55, Jan Beulich wrote: On 01.12.2020 00:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: --- a/xen/include/asm-arm/t

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Jan Beulich
On 01.12.2020 11:30, Julien Grall wrote: > Hi Jan, > > On 01/12/2020 07:55, Jan Beulich wrote: >> On 01.12.2020 00:27, Oleksandr wrote: >>> On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: > --- a/xen/include/asm-arm/traps.h > +++ b/xen/include/asm-arm/traps.h

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Oleksandr
On 01.12.20 12:30, Julien Grall wrote: Hi Julien Hi Jan, On 01/12/2020 07:55, Jan Beulich wrote: On 01.12.2020 00:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
Hi Jan, On 01/12/2020 07:55, Jan Beulich wrote: On 01.12.2020 00:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const st

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
On 30/11/2020 23:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Hi, Hi Volodymyr Oleksandr Tyshchenko writes: From: Oleksandr Tyshchenko In order to avoid code duplication (both handle_read() and handle_ioserv() contain the same code for the sign-extension) put th

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-11-30 Thread Jan Beulich
On 01.12.2020 00:27, Oleksandr wrote: > On 30.11.20 23:03, Volodymyr Babchuk wrote: >> Oleksandr Tyshchenko writes: >>> --- a/xen/include/asm-arm/traps.h >>> +++ b/xen/include/asm-arm/traps.h >>> @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const struct >>> cpu_user_regs *regs) >>>

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-11-30 Thread Oleksandr
On 30.11.20 23:03, Volodymyr Babchuk wrote: Hi, Hi Volodymyr Oleksandr Tyshchenko writes: From: Oleksandr Tyshchenko In order to avoid code duplication (both handle_read() and handle_ioserv() contain the same code for the sign-extension) put this code to a common helper to be used for

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-11-30 Thread Volodymyr Babchuk
Hi, Oleksandr Tyshchenko writes: > From: Oleksandr Tyshchenko > > In order to avoid code duplication (both handle_read() and > handle_ioserv() contain the same code for the sign-extension) > put this code to a common helper to be used for both. > > Signed-off-by: Oleksandr Tyshchenko > CC: Ju

[PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-11-30 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko In order to avoid code duplication (both handle_read() and handle_ioserv() contain the same code for the sign-extension) put this code to a common helper to be used for both. Signed-off-by: Oleksandr Tyshchenko CC: Julien Grall --- Please note, this is a split/clean