RE: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-17 Thread Paul Durrant
> -Original Message- [snip] > > Both hvm_ioreq_server_init() and hvm_ioreq_server_deinit() call "legacy" > hvm_ioreq_server_unmap_pages() > which we want to be abstracted. The only difference between these two > usages is that the former calls it during rollback only (in case of error). >

Re: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-17 Thread Oleksandr
On 17.11.20 17:29, Paul Durrant wrote: Hi Paul Thank you for the prompt answer. The 'legacy' mechanism of mapping magic pages for ioreq servers should remain x86 specific I think that aspect of the code needs to remain behind and not get moved into common code. You could do that in arch spec

RE: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-17 Thread Paul Durrant
x27;Jan Beulich' ; 'Julien Grall' > ; 'Stefano > Stabellini' ; 'Wei Liu' ; 'Roger Pau > Monné' > ; 'Tim Deegan' ; 'Julien Grall' > > Subject: Re: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common >

Re: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-17 Thread Oleksandr
Hi Paul The 'legacy' mechanism of mapping magic pages for ioreq servers should remain x86 specific I think that aspect of the code needs to remain behind and not get moved into common code. You could do that in arch specific calls in hvm_ioreq_server_enable/disable() and hvm_get_ioreq_ser

Re: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-13 Thread Oleksandr
On 12.11.20 13:11, Jan Beulich wrote: Hi Jan On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko As a lot of x86 code can be re-used on Arm later on, this patch moves previously prepared x86/hvm/ioreq.c to the common code. The common IOREQ feature is supposed to be

Re: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-12 Thread Jan Beulich
On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > As a lot of x86 code can be re-used on Arm later on, this patch > moves previously prepared x86/hvm/ioreq.c to the common code. > > The common IOREQ feature is supposed to be built with IOREQ_SERVER > option enable

Re: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-11-10 Thread Oleksandr
Grall ; Stefano Stabellini ; Wei Liu ; Roger Pau Monné ; Paul Durrant ; Tim Deegan ; Julien Grall Subject: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common From: Oleksandr Tyshchenko As a lot of x86 code can be re-used on Arm later on, this patch moves previously prepared x8

RE: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-10-20 Thread Paul Durrant
> Liu ; Roger Pau Monné ; Paul Durrant > ; Tim Deegan > ; Julien Grall > Subject: [PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common > > From: Oleksandr Tyshchenko > > As a lot of x86 code can be re-used on Arm later on, this patch > moves previousl

[PATCH V2 02/23] xen/ioreq: Make x86's IOREQ feature common

2020-10-15 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko As a lot of x86 code can be re-used on Arm later on, this patch moves previously prepared x86/hvm/ioreq.c to the common code. The common IOREQ feature is supposed to be built with IOREQ_SERVER option enabled, which is selected for x86's config HVM for now. In order to