Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-23 Thread Roger Pau Monné
On Fri, Apr 23, 2021 at 12:45:14PM +0200, Jan Beulich wrote: > On 23.04.2021 12:07, Roger Pau Monné wrote: > > On Fri, Apr 23, 2021 at 10:51:40AM +0200, Jan Beulich wrote: > >> On 23.04.2021 09:30, Roger Pau Monné wrote: > >>> /* > >>> * Explicitly list debug section for the PE output so that they

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-23 Thread Jan Beulich
On 23.04.2021 12:07, Roger Pau Monné wrote: > On Fri, Apr 23, 2021 at 10:51:40AM +0200, Jan Beulich wrote: >> On 23.04.2021 09:30, Roger Pau Monné wrote: >>> /* >>> * Explicitly list debug section for the PE output so that they don't >>> * end up at VA 0 which is below image base and thus invalid

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-23 Thread Roger Pau Monné
On Fri, Apr 23, 2021 at 10:51:40AM +0200, Jan Beulich wrote: > On 23.04.2021 09:30, Roger Pau Monné wrote: > > /* > > * Explicitly list debug section for the PE output so that they don't > > * end up at VA 0 which is below image base and thus invalid. Also use > > * the NOLOAD directive, even wh

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-23 Thread Jan Beulich
On 23.04.2021 09:30, Roger Pau Monné wrote: > On Thu, Apr 22, 2021 at 06:01:06PM +0200, Jan Beulich wrote: >> On 22.04.2021 17:53, Roger Pau Monné wrote: >>> On Thu, Apr 22, 2021 at 05:46:28PM +0200, Jan Beulich wrote: On 22.04.2021 16:56, Roger Pau Monné wrote: > On Thu, Apr 22, 2021 at 0

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-23 Thread Roger Pau Monné
On Thu, Apr 22, 2021 at 06:01:06PM +0200, Jan Beulich wrote: > On 22.04.2021 17:53, Roger Pau Monné wrote: > > On Thu, Apr 22, 2021 at 05:46:28PM +0200, Jan Beulich wrote: > >> On 22.04.2021 16:56, Roger Pau Monné wrote: > >>> On Thu, Apr 22, 2021 at 01:03:13PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-22 Thread Jan Beulich
On 22.04.2021 17:53, Roger Pau Monné wrote: > On Thu, Apr 22, 2021 at 05:46:28PM +0200, Jan Beulich wrote: >> On 22.04.2021 16:56, Roger Pau Monné wrote: >>> On Thu, Apr 22, 2021 at 01:03:13PM +0200, Jan Beulich wrote: On 22.04.2021 10:14, Roger Pau Monné wrote: > On Wed, Apr 21, 2021 at 0

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-22 Thread Roger Pau Monné
On Thu, Apr 22, 2021 at 05:46:28PM +0200, Jan Beulich wrote: > On 22.04.2021 16:56, Roger Pau Monné wrote: > > On Thu, Apr 22, 2021 at 01:03:13PM +0200, Jan Beulich wrote: > >> On 22.04.2021 10:14, Roger Pau Monné wrote: > >>> On Wed, Apr 21, 2021 at 05:38:42PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-22 Thread Jan Beulich
On 22.04.2021 16:56, Roger Pau Monné wrote: > On Thu, Apr 22, 2021 at 01:03:13PM +0200, Jan Beulich wrote: >> On 22.04.2021 10:14, Roger Pau Monné wrote: >>> On Wed, Apr 21, 2021 at 05:38:42PM +0200, Jan Beulich wrote: On 21.04.2021 17:30, Roger Pau Monné wrote: > On Wed, Apr 21, 2021 at 0

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-22 Thread Roger Pau Monné
On Thu, Apr 22, 2021 at 01:03:13PM +0200, Jan Beulich wrote: > On 22.04.2021 10:14, Roger Pau Monné wrote: > > On Wed, Apr 21, 2021 at 05:38:42PM +0200, Jan Beulich wrote: > >> On 21.04.2021 17:30, Roger Pau Monné wrote: > >>> On Wed, Apr 21, 2021 at 03:06:36PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-22 Thread Jan Beulich
On 22.04.2021 10:14, Roger Pau Monné wrote: > On Wed, Apr 21, 2021 at 05:38:42PM +0200, Jan Beulich wrote: >> On 21.04.2021 17:30, Roger Pau Monné wrote: >>> On Wed, Apr 21, 2021 at 03:06:36PM +0200, Jan Beulich wrote: On 21.04.2021 13:15, Roger Pau Monné wrote: > On Thu, Apr 01, 2021 at 1

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-22 Thread Roger Pau Monné
On Wed, Apr 21, 2021 at 05:38:42PM +0200, Jan Beulich wrote: > On 21.04.2021 17:30, Roger Pau Monné wrote: > > On Wed, Apr 21, 2021 at 03:06:36PM +0200, Jan Beulich wrote: > >> On 21.04.2021 13:15, Roger Pau Monné wrote: > >>> On Thu, Apr 01, 2021 at 11:47:03AM +0200, Jan Beulich wrote: > ---

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-21 Thread Jan Beulich
On 21.04.2021 17:30, Roger Pau Monné wrote: > On Wed, Apr 21, 2021 at 03:06:36PM +0200, Jan Beulich wrote: >> On 21.04.2021 13:15, Roger Pau Monné wrote: >>> On Thu, Apr 01, 2021 at 11:47:03AM +0200, Jan Beulich wrote: --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -312

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-21 Thread Roger Pau Monné
On Wed, Apr 21, 2021 at 03:06:36PM +0200, Jan Beulich wrote: > On 21.04.2021 13:15, Roger Pau Monné wrote: > > On Thu, Apr 01, 2021 at 11:47:03AM +0200, Jan Beulich wrote: > >> ... provided the linker supports it (which it does as of commit > >> 2dfa8341e079 ["ELF DWARF in PE output"]). > >> > >> W

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-21 Thread Jan Beulich
On 21.04.2021 13:15, Roger Pau Monné wrote: > On Thu, Apr 01, 2021 at 11:47:03AM +0200, Jan Beulich wrote: >> ... provided the linker supports it (which it does as of commit >> 2dfa8341e079 ["ELF DWARF in PE output"]). >> >> Without mentioning debugging sections, the linker would put them at >> VA

Re: [PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-21 Thread Roger Pau Monné
On Thu, Apr 01, 2021 at 11:47:03AM +0200, Jan Beulich wrote: > ... provided the linker supports it (which it does as of commit > 2dfa8341e079 ["ELF DWARF in PE output"]). > > Without mentioning debugging sections, the linker would put them at > VA 0, thus making them unreachable by 32-bit (relativ

[PATCH 7/8] x86/EFI: keep debug info in xen.efi

2021-04-01 Thread Jan Beulich
... provided the linker supports it (which it does as of commit 2dfa8341e079 ["ELF DWARF in PE output"]). Without mentioning debugging sections, the linker would put them at VA 0, thus making them unreachable by 32-bit (relative or absolute) relocations. If relocations were resolvable (or absent)