Re: [PATCH 7/7] video/vesa: adjust (not just) command line option handling

2021-05-27 Thread Jan Beulich
On 27.04.2021 16:04, Jan Beulich wrote: > On 27.04.2021 15:49, Andrew Cooper wrote: >> However, is there really any value in these options?  I can't see a case >> where their use will result in a less broken system. > > Well, if we mis-detect VRAM size, the respective option might indeed > help. I

Re: [PATCH 7/7] video/vesa: adjust (not just) command line option handling

2021-04-27 Thread Jan Beulich
On 27.04.2021 15:49, Andrew Cooper wrote: > On 27/04/2021 13:56, Jan Beulich wrote: > > The grammar in the subject is very awkward.  The (not just) like that is > weird. > > If it were me, I'd phrase this as "minor adjustments to command line > handling". Well, the (not just) is intentionally th

Re: [PATCH 7/7] video/vesa: adjust (not just) command line option handling

2021-04-27 Thread Andrew Cooper
On 27/04/2021 13:56, Jan Beulich wrote: The grammar in the subject is very awkward.  The (not just) like that is weird. If it were me, I'd phrase this as "minor adjustments to command line handling". > Document both options. Add section annotations to both variables holding > the parsed values a

[PATCH 7/7] video/vesa: adjust (not just) command line option handling

2021-04-27 Thread Jan Beulich
Document both options. Add section annotations to both variables holding the parsed values as well as a few adjacent ones. Adjust the types of font_height and vga_compat. Signed-off-by: Jan Beulich --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2369,9 +2369,2