Re: [PATCH 5/7] xen: Switch to new TRACE() API

2024-03-20 Thread Jan Beulich
On 20.03.2024 16:46, George Dunlap wrote: > On Wed, Mar 20, 2024 at 1:45 PM Jan Beulich wrote: >> >> On 18.03.2024 17:35, Andrew Cooper wrote: >>> @@ -736,9 +736,19 @@ static void vlapic_update_timer(struct vlapic *vlapic, >>> uint32_t lvtt, >>> delta = delta * vlapic->hw.timer_divis

Re: [PATCH 5/7] xen: Switch to new TRACE() API

2024-03-20 Thread George Dunlap
On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper wrote: > > (Almost) no functional change. > > irq_move_cleanup_interrupt() changes two smp_processor_id() calls to the 'me' > local variable which manifests as a minor code improvement. All other > differences in the compiled binary are to do with lin

Re: [PATCH 5/7] xen: Switch to new TRACE() API

2024-03-20 Thread George Dunlap
On Wed, Mar 20, 2024 at 1:45 PM Jan Beulich wrote: > > On 18.03.2024 17:35, Andrew Cooper wrote: > > @@ -736,9 +736,19 @@ static void vlapic_update_timer(struct vlapic *vlapic, > > uint32_t lvtt, > > delta = delta * vlapic->hw.timer_divisor / old_divisor; > > } > > > > -

Re: [PATCH 5/7] xen: Switch to new TRACE() API

2024-03-20 Thread Jan Beulich
On 18.03.2024 17:35, Andrew Cooper wrote: > @@ -736,9 +736,19 @@ static void vlapic_update_timer(struct vlapic *vlapic, > uint32_t lvtt, > delta = delta * vlapic->hw.timer_divisor / old_divisor; > } > > -TRACE_2_LONG_3D(TRC_HVM_EMUL_LAPIC_START_TIMER, TRC_PAR_LONG(d

[PATCH 5/7] xen: Switch to new TRACE() API

2024-03-18 Thread Andrew Cooper
(Almost) no functional change. irq_move_cleanup_interrupt() changes two smp_processor_id() calls to the 'me' local variable which manifests as a minor code improvement. All other differences in the compiled binary are to do with line numbers changing. Some conversion notes: * HVMTRACE_LONG_[234