Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-22 Thread Jan Beulich
On 22.02.2024 12:00, George Dunlap wrote: > On Thu, Feb 22, 2024 at 5:50 PM Jan Beulich wrote: >> >> On 22.02.2024 10:30, George Dunlap wrote: >>> On Wed, Feb 21, 2024 at 6:52 PM Jan Beulich wrote: >> But then of course Andrew may know of reasons why all of this is done >> in calculate_ho

Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-22 Thread George Dunlap
On Thu, Feb 22, 2024 at 5:50 PM Jan Beulich wrote: > > On 22.02.2024 10:30, George Dunlap wrote: > > On Wed, Feb 21, 2024 at 6:52 PM Jan Beulich wrote: > But then of course Andrew may know of reasons why all of this is done > in calculate_host_policy() in the first place, rather than in

Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-22 Thread Jan Beulich
On 22.02.2024 10:30, George Dunlap wrote: > On Wed, Feb 21, 2024 at 6:52 PM Jan Beulich wrote: But then of course Andrew may know of reasons why all of this is done in calculate_host_policy() in the first place, rather than in HVM policy calculation. >>> >>> It sounds like maybe you

Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-22 Thread George Dunlap
On Wed, Feb 21, 2024 at 6:52 PM Jan Beulich wrote: > >> But then of course Andrew may know of reasons why all of this is done > >> in calculate_host_policy() in the first place, rather than in HVM > >> policy calculation. > > > > It sounds like maybe you're confusing host_policy with > > x86_capab

Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-21 Thread Jan Beulich
On 21.02.2024 09:48, George Dunlap wrote: > On Mon, Feb 19, 2024 at 11:22 PM Jan Beulich wrote: >> >> On 06.02.2024 02:20, George Dunlap wrote: >>> For now, just disable the functionality entirely until we can >>> implement it properly: >>> >>> - Don't set TSCRATEMSR in the host CPUID policy >> >>

Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-21 Thread George Dunlap
On Mon, Feb 19, 2024 at 11:22 PM Jan Beulich wrote: > > On 06.02.2024 02:20, George Dunlap wrote: > > For now, just disable the functionality entirely until we can > > implement it properly: > > > > - Don't set TSCRATEMSR in the host CPUID policy > > This goes too far: This way you would (in princ

Re: [PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-19 Thread Jan Beulich
On 06.02.2024 02:20, George Dunlap wrote: > For now, just disable the functionality entirely until we can > implement it properly: > > - Don't set TSCRATEMSR in the host CPUID policy This goes too far: This way you would (in principle) also affect guests with nesting disabled. According to the ea

[PATCH 4/6] nestedsvm: Disable TscRateMSR

2024-02-05 Thread George Dunlap
The primary purpose of TSC scaling, from our perspective, is to maintain the fiction of an "invariant TSC" across migrates between platforms with different clock speeds. On AMD, the TscRateMSR CPUID bit is unconditionally enabled in the "host cpuid", even if the hardware doesn't actually support i