Re: [PATCH 4/4] x86/hvmloader: Move various helpers to being static inlines

2022-08-25 Thread Jan Beulich
On 24.08.2022 12:59, Andrew Cooper wrote: > The IO port, MSR, IO-APIC and LAPIC accessors compile typically to single or > pairs of instructions, which is less overhead than even the stack manipulation > to call the helpers. > > Move the implementations from util.c to being static inlines in util.

[PATCH 4/4] x86/hvmloader: Move various helpers to being static inlines

2022-08-24 Thread Andrew Cooper
The IO port, MSR, IO-APIC and LAPIC accessors compile typically to single or pairs of instructions, which is less overhead than even the stack manipulation to call the helpers. Move the implementations from util.c to being static inlines in util.h In addition, turn ioapic_base_address into a cons