Re: [PATCH 3/7] xen: remove -N from the linker command line

2025-03-21 Thread Oleksii Kurochko
On 3/18/25 6:35 PM, Roger Pau Monne wrote: It's unclear why -N is being used in the first place. It was added by commit 40828c657dd0c back in 2004 without any justification. When building a PE image it's actually detrimental to forcefully set the .text section as writable. The GNU LD man page

Re: [PATCH 3/7] xen: remove -N from the linker command line

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:35, Roger Pau Monne wrote: > It's unclear why -N is being used in the first place. It was added by > commit 40828c657dd0c back in 2004 without any justification. Not really, no. That only moved it from LDFLAGS to an explicit use. Several hops earlier it looks to be 4676bbf96dc8 (

[PATCH 3/7] xen: remove -N from the linker command line

2025-03-18 Thread Roger Pau Monne
It's unclear why -N is being used in the first place. It was added by commit 40828c657dd0c back in 2004 without any justification. When building a PE image it's actually detrimental to forcefully set the .text section as writable. The GNU LD man page contains the following warning regarding the

Re: [PATCH 3/7] xen: remove -N from the linker command line

2025-03-18 Thread Andrew Cooper
On 18/03/2025 5:35 pm, Roger Pau Monne wrote: > It's unclear why -N is being used in the first place. It was added by > commit 40828c657dd0c back in 2004 without any justification. > > When building a PE image it's actually detrimental to forcefully set the > .text section as writable. The GNU LD