Hi,
On 22/06/2023 19:54, Shawn Anastasio wrote:
On 6/22/23 11:43 AM, Julien Grall wrote:
Hi,
Thanks for the response. I had one more question with regards to the
emacs footer.
All files usually have an emacs magic block. E.g.:
/*
* Local variables:
* mode: C
* c-file-style: "BSD"
* c-basic
On 6/22/23 11:43 AM, Julien Grall wrote:
> Hi,
Thanks for the response. I had one more question with regards to the
emacs footer.
>All files usually have an emacs magic block. E.g.:
>
>/*
> * Local variables:
> * mode: C
> * c-file-style: "BSD"
> * c-basic-offset: 4
> * indent-tabs-mode: nil
> *
Hi,
On 22/06/2023 17:05, Shawn Anastasio wrote:
On 6/21/23 3:48 PM, Julien Grall wrote:
On 21/06/2023 17:59, Shawn Anastasio wrote:
diff --git a/xen/arch/ppc/boot-of.c b/xen/arch/ppc/boot-of.c
new file mode 100644
index 00..1ceeaf1250
--- /dev/null
+++ b/xen/arch/ppc/boot-of.c
@@ -0,0
On 6/21/23 3:48 PM, Julien Grall wrote:
> Hi Shawn,
>
> Below some remark about the coding style. I will try to spot all of them
> so please go through your code and check if my comments applies in other
> places.
Thank you for the detailed comments. I had a couple of follow-up
questions for you.
On 6/22/23 3:03 AM, Jan Beulich wrote:
> On 21.06.2023 20:21, Shawn Anastasio wrote:
>> On 6/21/23 12:54 PM, Andrew Cooper wrote:
>>> Given:
>>>
>>> #define r0 0
>>>
>>> do the assemblers really not understand register names? That seems mad.
>>
>> Yeah as surprising as it is, ppc64 assemblers don
On 21.06.2023 20:21, Shawn Anastasio wrote:
> On 6/21/23 12:54 PM, Andrew Cooper wrote:
>> Given:
>>
>> #define r0 0
>>
>> do the assemblers really not understand register names? That seems mad.
>
> Yeah as surprising as it is, ppc64 assemblers don't handle register
> names by default. I think a
Hi Shawn,
Below some remark about the coding style. I will try to spot all of them
so please go through your code and check if my comments applies in other
places.
On 21/06/2023 17:59, Shawn Anastasio wrote:
On typical Power VMs (e.g. QEMU's -M pseries), a variety of services
including an ea
On 6/21/23 12:54 PM, Andrew Cooper wrote:
> I've noticed a couple of other things. asm/types.h repeats some
> antipatterns which we're trying to delete for MISRA reasons in other
> architectures. I was already planning to fix that up xen-wide, and I
> guess now is the better time to do so.
Could
On 21/06/2023 7:21 pm, Shawn Anastasio wrote:
> On 6/21/23 12:54 PM, Andrew Cooper wrote:
>> On 21/06/2023 5:59 pm, Shawn Anastasio wrote:
>>> xen/arch/ppc/Kconfig.debug | 5 +
>>> xen/arch/ppc/Makefile | 3 +
>>> xen/arch/ppc/boot-of.c | 116 +++
On 6/21/23 12:54 PM, Andrew Cooper wrote:
> On 21/06/2023 5:59 pm, Shawn Anastasio wrote:
>> xen/arch/ppc/Kconfig.debug | 5 +
>> xen/arch/ppc/Makefile | 3 +
>> xen/arch/ppc/boot-of.c | 116 +
>> xen/arch/ppc/configs/ppc64_defconfig
On 21/06/2023 5:59 pm, Shawn Anastasio wrote:
> xen/arch/ppc/Kconfig.debug | 5 +
> xen/arch/ppc/Makefile | 3 +
> xen/arch/ppc/boot-of.c | 116 +
> xen/arch/ppc/configs/ppc64_defconfig| 1 +
> xen/arch/ppc/early_printk.c
On typical Power VMs (e.g. QEMU's -M pseries), a variety of services
including an early serial console are provided by Open Firmware.
Implement the required interfaces to call into Open Firmware and write
to the serial console.
Since Open Firmware runs in 32-bit Big Endian mode and Xen runs in
64-
12 matches
Mail list logo
