Re: [PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-20 Thread George Dunlap
On Wed, Mar 20, 2024 at 12:16 PM George Dunlap wrote: > > On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper > wrote: > > > > There is no need for bitfields anywhere - use more sensible types. There is > > also no need to cast 'd' to (unsigned char *) before passing it to a > > function > > taking

Re: [PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-20 Thread George Dunlap
On Wed, Mar 20, 2024 at 1:13 PM Jan Beulich wrote: > > On 20.03.2024 13:19, Andrew Cooper wrote: > > On 20/03/2024 12:16 pm, George Dunlap wrote: > >> On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper > >> wrote: > >>> There is no need for bitfields anywhere - use more sensible types. There > >>>

Re: [PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-20 Thread Jan Beulich
On 20.03.2024 13:19, Andrew Cooper wrote: > On 20/03/2024 12:16 pm, George Dunlap wrote: >> On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper >> wrote: >>> There is no need for bitfields anywhere - use more sensible types. There is >>> also no need to cast 'd' to (unsigned char *) before passing it

Re: [PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-20 Thread George Dunlap
On Wed, Mar 20, 2024 at 12:19 PM Andrew Cooper wrote: > > On 20/03/2024 12:16 pm, George Dunlap wrote: > > On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper > > wrote: > >> There is no need for bitfields anywhere - use more sensible types. There > >> is > >> also no need to cast 'd' to (unsigned c

Re: [PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-20 Thread Andrew Cooper
On 20/03/2024 12:16 pm, George Dunlap wrote: > On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper > wrote: >> There is no need for bitfields anywhere - use more sensible types. There is >> also no need to cast 'd' to (unsigned char *) before passing it to a function >> taking void *. Switch to new t

Re: [PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-20 Thread George Dunlap
On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper wrote: > > There is no need for bitfields anywhere - use more sensible types. There is > also no need to cast 'd' to (unsigned char *) before passing it to a function > taking void *. Switch to new trace_time() API. > > No functional change. Hey And

[PATCH 2/7] xen/credit2: Clean up trace handling

2024-03-18 Thread Andrew Cooper
There is no need for bitfields anywhere - use more sensible types. There is also no need to cast 'd' to (unsigned char *) before passing it to a function taking void *. Switch to new trace_time() API. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Reviewed-by: Dar