Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-05-01 Thread George Dunlap
On Wed, May 1, 2024 at 11:39 AM Andrew Cooper wrote: > > On 01/05/2024 11:00 am, George Dunlap wrote: > > On Mon, Apr 29, 2024 at 4:16 PM Andrew Cooper > > wrote: > >> These will replace svm_feature_flags and the SVM_FEATURE_* constants over > >> the > >> next few changes. Take the opportunity

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-05-01 Thread Andrew Cooper
On 01/05/2024 11:00 am, George Dunlap wrote: > On Mon, Apr 29, 2024 at 4:16 PM Andrew Cooper > wrote: >> These will replace svm_feature_flags and the SVM_FEATURE_* constants over the >> next few changes. Take the opportunity to rationalise some names. >> >> Drop the opencoded "inherit from host"

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-05-01 Thread George Dunlap
On Mon, Apr 29, 2024 at 4:16 PM Andrew Cooper wrote: > > These will replace svm_feature_flags and the SVM_FEATURE_* constants over the > next few changes. Take the opportunity to rationalise some names. > > Drop the opencoded "inherit from host" logic in calculate_hvm_max_policy() and > use 'h'/'

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-04-30 Thread Jan Beulich
On 29.04.2024 17:16, Andrew Cooper wrote: > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -358,6 +358,20 @@ XEN_CPUFEATURE(RFDS_CLEAR, 16*32+28) /*!A > Register File(s) cleared by VE > /* Intel-defined CPU features, MSR_ARCH_CAP

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-04-29 Thread Andrew Cooper
On 29/04/2024 4:16 pm, Andrew Cooper wrote: > diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py > index bf3f9ec01e6e..f07b1f4cf905 100755 > --- a/xen/tools/gen-cpuid.py > +++ b/xen/tools/gen-cpuid.py > @@ -280,6 +280,9 @@ def crunch_numbers(state): > # standard 3DNow in the earl

[PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-04-29 Thread Andrew Cooper
These will replace svm_feature_flags and the SVM_FEATURE_* constants over the next few changes. Take the opportunity to rationalise some names. Drop the opencoded "inherit from host" logic in calculate_hvm_max_policy() and use 'h'/'!' annotations. The logic needs to operate on fs, not the policy