Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2023-04-03 Thread Jan Beulich
On 31.03.2023 09:37, Roger Pau Monné wrote: > On Fri, Mar 31, 2023 at 08:51:46AM +0200, Jan Beulich wrote: >> On 30.03.2023 18:17, Roger Pau Monné wrote: >>> On Thu, Mar 30, 2023 at 06:07:57PM +0200, Jan Beulich wrote: On 30.03.2023 17:44, Roger Pau Monné wrote: > I guess I'm slightly conf

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2023-03-31 Thread Roger Pau Monné
On Fri, Mar 31, 2023 at 08:51:46AM +0200, Jan Beulich wrote: > On 30.03.2023 18:17, Roger Pau Monné wrote: > > On Thu, Mar 30, 2023 at 06:07:57PM +0200, Jan Beulich wrote: > >> On 30.03.2023 17:44, Roger Pau Monné wrote: > >>> I guess I'm slightly confused by the usage of both GOP and StdOut, I > >

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2023-03-30 Thread Jan Beulich
On 30.03.2023 18:17, Roger Pau Monné wrote: > On Thu, Mar 30, 2023 at 06:07:57PM +0200, Jan Beulich wrote: >> On 30.03.2023 17:44, Roger Pau Monné wrote: >>> I guess I'm slightly confused by the usage of both GOP and StdOut, I >>> would assume if we have a gop, and can correctly initialize it there

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2023-03-30 Thread Roger Pau Monné
On Thu, Mar 30, 2023 at 06:07:57PM +0200, Jan Beulich wrote: > On 30.03.2023 17:44, Roger Pau Monné wrote: > > On Mon, Dec 05, 2022 at 03:19:13PM +0100, Jan Beulich wrote: > >> On 23.11.2022 16:45, Roger Pau Monne wrote: > >>> Do not unconditionally set a mode in efi_console_set_mode(), do so > >>>

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2023-03-30 Thread Jan Beulich
On 30.03.2023 17:44, Roger Pau Monné wrote: > On Mon, Dec 05, 2022 at 03:19:13PM +0100, Jan Beulich wrote: >> On 23.11.2022 16:45, Roger Pau Monne wrote: >>> Do not unconditionally set a mode in efi_console_set_mode(), do so >>> only if the currently set mode is not valid. >> >> You don't say why y

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2023-03-30 Thread Roger Pau Monné
On Mon, Dec 05, 2022 at 03:19:13PM +0100, Jan Beulich wrote: > On 23.11.2022 16:45, Roger Pau Monne wrote: > > Do not unconditionally set a mode in efi_console_set_mode(), do so > > only if the currently set mode is not valid. > > You don't say why you want to do so. Furthermore ... > > > --- a/x

Re: [PATCH 2/5] efi: only set a console mode if the current one is invalid

2022-12-05 Thread Jan Beulich
On 23.11.2022 16:45, Roger Pau Monne wrote: > Do not unconditionally set a mode in efi_console_set_mode(), do so > only if the currently set mode is not valid. You don't say why you want to do so. Furthermore ... > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -799,6 +799,11 @@ s

[PATCH 2/5] efi: only set a console mode if the current one is invalid

2022-11-23 Thread Roger Pau Monne
Do not unconditionally set a mode in efi_console_set_mode(), do so only if the currently set mode is not valid. Signed-off-by: Roger Pau Monné --- xen/common/efi/boot.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index db0340c8e2..7e8a8b