Re: [PATCH 2/4] x86/svm: cleanup svm.h

2023-02-21 Thread Andrew Cooper
On 21/02/2023 7:58 am, Xenia Ragiadakou wrote: > > On 2/21/23 01:08, Andrew Cooper wrote: >> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>> Remove the forward declaration of struct vcpu because it is not used. >> >> Huh, turns out that was my fault in c/s b158e72abe, shortly after I >> introduc

Re: [PATCH 2/4] x86/svm: cleanup svm.h

2023-02-20 Thread Xenia Ragiadakou
On 2/21/23 01:08, Andrew Cooper wrote: On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: Remove the forward declaration of struct vcpu because it is not used. Huh, turns out that was my fault in c/s b158e72abe, shortly after I introduced them in the first place. Also, looking into that, there'

Re: [PATCH 2/4] x86/svm: cleanup svm.h

2023-02-20 Thread Andrew Cooper
On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: > Remove the forward declaration of struct vcpu because it is not used. Huh, turns out that was my fault in c/s b158e72abe, shortly after I introduced them in the first place. Also, looking into that, there's one legitimate use of svm.h from outside,

[PATCH 2/4] x86/svm: cleanup svm.h

2023-02-17 Thread Xenia Ragiadakou
Remove the forward declaration of struct vcpu because it is not used. Move the forward declaration of struct cpu_user_regs just above the function that needs it (to remind that it will need to be removed along with the function). Move the definitions of NPT_PFEC_with_gla and NPT_PFEC_in_gpt in sv