Re: [PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-21 Thread David Woodhouse
On Tue, 2023-11-21 at 14:58 +0400, Marc-André Lureau wrote: > > > Consistent with the rest of the lines (no conditional compilation nor > > driver #define..) > > Reviewed-by: Marc-André Lureau Thanks. > > btw, while quickly testing this (do we have any test for xen-console?): > > > > $ qemu --

Re: [PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-21 Thread Paul Durrant
On 15/11/2023 17:24, David Woodhouse wrote: From: David Woodhouse If a Xen console is configured on the command line, do not add a default serial port. Signed-off-by: David Woodhouse --- system/vl.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Paul Durrant

Re: [PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-21 Thread Marc-André Lureau
Hi On Tue, Nov 21, 2023 at 2:57 PM Marc-André Lureau wrote: > > Hi > > On Wed, Nov 15, 2023 at 9:28 PM David Woodhouse wrote: > > > > From: David Woodhouse > > > > If a Xen console is configured on the command line, do not add a default > > serial port. > > > > Signed-off-by: David Woodhouse >

Re: [PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-21 Thread Marc-André Lureau
Hi On Wed, Nov 15, 2023 at 9:28 PM David Woodhouse wrote: > > From: David Woodhouse > > If a Xen console is configured on the command line, do not add a default > serial port. > > Signed-off-by: David Woodhouse > --- > system/vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/system

[PATCH 2/3] vl: disable default serial when xen-console is enabled

2023-11-15 Thread David Woodhouse
From: David Woodhouse If a Xen console is configured on the command line, do not add a default serial port. Signed-off-by: David Woodhouse --- system/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/system/vl.c b/system/vl.c index 5af7ced2a1..8109231834 100644 --- a/system/vl.c +++ b/s