Re: [PATCH 2/3] gnttab: consolidate pin-to-status syncing

2021-01-15 Thread Andrew Cooper
On 15/01/2021 13:33, Jan Beulich wrote: > On 15.01.2021 14:25, Andrew Cooper wrote: >> On 14/01/2021 15:23, Jan Beulich wrote: >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -908,6 +908,25 @@ static int _set_status(const grant_entry >>> return _set_status_v2(s

Re: [PATCH 2/3] gnttab: consolidate pin-to-status syncing

2021-01-15 Thread Jan Beulich
On 15.01.2021 14:25, Andrew Cooper wrote: > On 14/01/2021 15:23, Jan Beulich wrote: >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -908,6 +908,25 @@ static int _set_status(const grant_entry >> return _set_status_v2(shah, status, rd, act, readonly, mapflag, >> ld

Re: [PATCH 2/3] gnttab: consolidate pin-to-status syncing

2021-01-15 Thread Andrew Cooper
On 14/01/2021 15:23, Jan Beulich wrote: > Forever since the fix for XSA-230 the 2nd of the comments ahead of > fixup_status_for_copy_pin() has been stale - there's nothing specific to > transitive grants there anymore. > > Move the function up, drop the "copy" part from its name again, add a > "rea

[PATCH 2/3] gnttab: consolidate pin-to-status syncing

2021-01-14 Thread Jan Beulich
Forever since the fix for XSA-230 the 2nd of the comments ahead of fixup_status_for_copy_pin() has been stale - there's nothing specific to transitive grants there anymore. Move the function up, drop the "copy" part from its name again, add a "readonly" parameter, and use it also on other paths ha