Re: Ping: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-09-29 Thread Roger Pau Monné
On Tue, Sep 29, 2020 at 12:58:20PM +0200, Jan Beulich wrote: > On 29.09.2020 12:27, Roger Pau Monné wrote: > > On Mon, Sep 21, 2020 at 12:05:51PM +0200, Jan Beulich wrote: > >> On 21.08.2020 09:45, Jan Beulich wrote: > >>> On 20.08.2020 18:28, Andrew Cooper wrote: > On 20/08/2020 16:34, Roger

Re: Ping: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-09-29 Thread Jan Beulich
On 29.09.2020 12:27, Roger Pau Monné wrote: > On Mon, Sep 21, 2020 at 12:05:51PM +0200, Jan Beulich wrote: >> On 21.08.2020 09:45, Jan Beulich wrote: >>> On 20.08.2020 18:28, Andrew Cooper wrote: On 20/08/2020 16:34, Roger Pau Monne wrote: > Currently the dpci EOI callback is only executed

Re: Ping: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-09-29 Thread Roger Pau Monné
On Mon, Sep 21, 2020 at 12:05:51PM +0200, Jan Beulich wrote: > On 21.08.2020 09:45, Jan Beulich wrote: > > On 20.08.2020 18:28, Andrew Cooper wrote: > >> On 20/08/2020 16:34, Roger Pau Monne wrote: > >>> Currently the dpci EOI callback is only executed for specific EOIs. > >>> This is wrong as non-

Ping: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-09-21 Thread Jan Beulich
On 21.08.2020 09:45, Jan Beulich wrote: > On 20.08.2020 18:28, Andrew Cooper wrote: >> On 20/08/2020 16:34, Roger Pau Monne wrote: >>> Currently the dpci EOI callback is only executed for specific EOIs. >>> This is wrong as non-specific EOIs will also clear the ISR bit and >>> thus end the interrup

Re: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-08-21 Thread Jan Beulich
On 20.08.2020 18:28, Andrew Cooper wrote: > On 20/08/2020 16:34, Roger Pau Monne wrote: >> Currently the dpci EOI callback is only executed for specific EOIs. >> This is wrong as non-specific EOIs will also clear the ISR bit and >> thus end the interrupt. Re-arrange the code a bit so that the commo

Re: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-08-20 Thread Roger Pau Monné
On Thu, Aug 20, 2020 at 05:28:21PM +0100, Andrew Cooper wrote: > On 20/08/2020 16:34, Roger Pau Monne wrote: > > Currently the dpci EOI callback is only executed for specific EOIs. > > This is wrong as non-specific EOIs will also clear the ISR bit and > > thus end the interrupt. Re-arrange the code

Re: [PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-08-20 Thread Andrew Cooper
On 20/08/2020 16:34, Roger Pau Monne wrote: > Currently the dpci EOI callback is only executed for specific EOIs. > This is wrong as non-specific EOIs will also clear the ISR bit and > thus end the interrupt. Re-arrange the code a bit so that the common > EOI handling path can be shared between all

[PATCH 2/2] x86/vpic: also execute dpci callback for non-specific EOI

2020-08-20 Thread Roger Pau Monne
Currently the dpci EOI callback is only executed for specific EOIs. This is wrong as non-specific EOIs will also clear the ISR bit and thus end the interrupt. Re-arrange the code a bit so that the common EOI handling path can be shared between all EOI modes. Signed-off-by: Roger Pau Monné --- xe