Re: [PATCH 2/2] x86/vPIT: account for "counter stopped" time

2023-06-06 Thread Roger Pau Monné
On Thu, Jun 01, 2023 at 04:20:13PM +0200, Jan Beulich wrote: > On 01.06.2023 13:48, Roger Pau Monné wrote: > > On Tue, May 30, 2023 at 05:30:40PM +0200, Jan Beulich wrote: > >> TBD: "gate" can only ever be low for chan2 (with "x86/vPIT: check/bound > >> values loaded from state save record" [2

Re: [PATCH 2/2] x86/vPIT: account for "counter stopped" time

2023-06-01 Thread Jan Beulich
On 01.06.2023 13:48, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 05:30:40PM +0200, Jan Beulich wrote: >> TBD: "gate" can only ever be low for chan2 (with "x86/vPIT: check/bound >> values loaded from state save record" [2] in place), so in >> principle we could get away without a new

Re: [PATCH 2/2] x86/vPIT: account for "counter stopped" time

2023-06-01 Thread Roger Pau Monné
On Tue, May 30, 2023 at 05:30:40PM +0200, Jan Beulich wrote: > For an approach like that used in "x86: detect PIT aliasing on ports > other than 0x4[0-3]" [1] to work, channel 2 may not (appear to) continue > counting when "gate" is low. Record the time when "gate" goes low, and > adjust pit_get_{c

[PATCH 2/2] x86/vPIT: account for "counter stopped" time

2023-05-30 Thread Jan Beulich
For an approach like that used in "x86: detect PIT aliasing on ports other than 0x4[0-3]" [1] to work, channel 2 may not (appear to) continue counting when "gate" is low. Record the time when "gate" goes low, and adjust pit_get_{count,out}() accordingly. Additionally for most of the modes a rising