Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Jan Beulich
On 13.11.2024 12:36, Andrew Cooper wrote: > On 13/11/2024 9:30 am, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h >> index 7930b7c73892..9d3f2b71447e 100644 >> --- a/xen/arch/x86/efi/efi-boot.h >> +++ b/xen/arch/x86/efi/efi-boot.h >> @@ -633,7 +633,7

[PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Andrew Cooper
The logic is far more sane to follow with a total size, and the position of the end of the heap. Remove or fix the the remaining descriptions of how the trampoline is laid out. No functional change. The compiled binary is identical. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger P

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Frediano Ziglio
On Wed, Nov 13, 2024 at 11:36 AM Andrew Cooper wrote: > > On 13/11/2024 9:30 am, Andrew Cooper wrote: > > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > > index 7930b7c73892..9d3f2b71447e 100644 > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h >

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Jan Beulich
On 13.11.2024 12:52, Andrew Cooper wrote: > On 13/11/2024 10:23 am, Jan Beulich wrote: >> On 13.11.2024 10:30, Andrew Cooper wrote: >>> --- a/xen/arch/x86/include/asm/config.h >>> +++ b/xen/arch/x86/include/asm/config.h >>> @@ -51,8 +51,9 @@ >>> >>> #define IST_SHSTK_SIZE 1024 >>> >>> -#define

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Andrew Cooper
On 13/11/2024 10:23 am, Jan Beulich wrote: > On 13.11.2024 10:30, Andrew Cooper wrote: >> --- a/xen/arch/x86/include/asm/config.h >> +++ b/xen/arch/x86/include/asm/config.h >> @@ -51,8 +51,9 @@ >> >> #define IST_SHSTK_SIZE 1024 >> >> -#define TRAMPOLINE_STACK_SPACE PAGE_SIZE >> -#define TRAMP

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Andrew Cooper
On 13/11/2024 9:30 am, Andrew Cooper wrote: > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > index 7930b7c73892..9d3f2b71447e 100644 > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -633,7 +633,7 @@ static void __init efi_arch_memory_setup(void)

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Jan Beulich
On 13.11.2024 10:30, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/config.h > +++ b/xen/arch/x86/include/asm/config.h > @@ -51,8 +51,9 @@ > > #define IST_SHSTK_SIZE 1024 > > -#define TRAMPOLINE_STACK_SPACE PAGE_SIZE > -#define TRAMPOLINE_SPACE(KB(64) - TRAMPOLINE_STACK_SPACE)

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Frediano Ziglio
On Wed, Nov 13, 2024 at 10:18 AM Frediano Ziglio wrote: > > On Wed, Nov 13, 2024 at 9:31 AM Andrew Cooper > wrote: > > > > The logic is far more sane to follow with a total size, and the position of > > the end of the heap. Remove or fix the the remaining descriptions of how > > the > > typo:

Re: [PATCH 2/2] x86/trampoline: Rationalise the constants to describe the size

2024-11-13 Thread Frediano Ziglio
On Wed, Nov 13, 2024 at 9:31 AM Andrew Cooper wrote: > > The logic is far more sane to follow with a total size, and the position of > the end of the heap. Remove or fix the the remaining descriptions of how the typo: the the > trampoline is laid out. > > No functional change. The compiled bin