Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-10 Thread Roger Pau Monné
On Tue, Apr 08, 2025 at 03:00:28PM +0100, Andrew Cooper wrote: > On 08/04/2025 10:31 am, Roger Pau Monne wrote: > > When running on AMD hardware in HVM mode the guest linear address (GLA) > > will not be provided to hvm_emulate_one_mmio(), and instead is > > unconditionally set of ~0. As a consequ

[PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-10 Thread Roger Pau Monne
When running on AMD hardware in HVM mode the guest linear address (GLA) will not be provided to hvm_emulate_one_mmio(), and instead is unconditionally set of ~0. As a consequence mmio_ro_emulated_write() will always report an error, as the fault GLA generated by the emulation of the access won't b

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-10 Thread Roger Pau Monné
On Thu, Apr 10, 2025 at 08:27:49AM +0200, Jan Beulich wrote: > On 09.04.2025 17:33, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 04:08:47PM +0200, Jan Beulich wrote: > >> On 09.04.2025 16:01, Roger Pau Monné wrote: > >>> As I understand the checks done in > >>> mmio_ro_emulated_write() are t

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 17:33, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 04:08:47PM +0200, Jan Beulich wrote: >> On 09.04.2025 16:01, Roger Pau Monné wrote: >>> As I understand the checks done in >>> mmio_ro_emulated_write() are to ensure correctness, but carrying the >>> access even when the %cr2 ch

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 04:08:47PM +0200, Jan Beulich wrote: > On 09.04.2025 16:01, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 03:50:13PM +0200, Jan Beulich wrote: > >> On 09.04.2025 15:33, Roger Pau Monné wrote: > >>> On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: > On 0

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Marek Marczykowski
On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > On 08.04.2025 11:31, Roger Pau Monne wrote: > > When running on AMD hardware in HVM mode the guest linear address (GLA) > > will not be provided to hvm_emulate_one_mmio(), and instead is > > unconditionally set of ~0. As a consequence

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 16:01, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 03:50:13PM +0200, Jan Beulich wrote: >> On 09.04.2025 15:33, Roger Pau Monné wrote: >>> On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: On 09.04.2025 12:39, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 1

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 03:50:13PM +0200, Jan Beulich wrote: > On 09.04.2025 15:33, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: > >> On 09.04.2025 12:39, Roger Pau Monné wrote: > >>> On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: > On 0

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 15:33, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: >> On 09.04.2025 12:39, Roger Pau Monné wrote: >>> On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: On 09.04.2025 11:07, Roger Pau Monné wrote: > On Tue, Apr 08, 2025 at 0

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: > On 09.04.2025 12:39, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: > >> On 09.04.2025 11:07, Roger Pau Monné wrote: > >>> On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > On 0

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 12:39, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: >> On 09.04.2025 11:07, Roger Pau Monné wrote: >>> On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: On 08.04.2025 11:31, Roger Pau Monne wrote: > When running on AMD hardw

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: > On 09.04.2025 11:07, Roger Pau Monné wrote: > > On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > >> On 08.04.2025 11:31, Roger Pau Monne wrote: > >>> When running on AMD hardware in HVM mode the guest linear address (GLA)

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 11:07, Roger Pau Monné wrote: > On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: >> On 08.04.2025 11:31, Roger Pau Monne wrote: >>> When running on AMD hardware in HVM mode the guest linear address (GLA) >>> will not be provided to hvm_emulate_one_mmio(), and instead is >>

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > On 08.04.2025 11:31, Roger Pau Monne wrote: > > When running on AMD hardware in HVM mode the guest linear address (GLA) > > will not be provided to hvm_emulate_one_mmio(), and instead is > > unconditionally set of ~0. As a consequence

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-08 Thread Andrew Cooper
On 08/04/2025 10:31 am, Roger Pau Monne wrote: > When running on AMD hardware in HVM mode the guest linear address (GLA) > will not be provided to hvm_emulate_one_mmio(), and instead is > unconditionally set of ~0. As a consequence mmio_ro_emulated_write() will > always report an error, as the fau

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-08 Thread Jan Beulich
On 08.04.2025 11:31, Roger Pau Monne wrote: > When running on AMD hardware in HVM mode the guest linear address (GLA) > will not be provided to hvm_emulate_one_mmio(), and instead is > unconditionally set of ~0. As a consequence mmio_ro_emulated_write() will > always report an error, as the fault