Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-18 Thread Luca Fancellu
+ Adding toolstack maintainer > On 18 May 2022, at 12:34, Andrew Cooper wrote: > > On 18/05/2022 11:30, Luca Fancellu wrote: >>> On 18 May 2022, at 11:12, Andrew Cooper wrote: >>> >>> On 18/05/2022 10:51, Edwin Torok wrote: > diff --git a/tools/ocaml/libs/xc/xenctrl.ml > b/tools/ocaml

Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-18 Thread Andrew Cooper
On 18/05/2022 11:30, Luca Fancellu wrote: >> On 18 May 2022, at 11:12, Andrew Cooper wrote: >> >> On 18/05/2022 10:51, Edwin Torok wrote: diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 7503031d8f61..8eab6f60eb14 100644 --- a/tools/ocaml/libs

Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-18 Thread Luca Fancellu
> On 18 May 2022, at 11:12, Andrew Cooper wrote: > > On 18/05/2022 10:51, Edwin Torok wrote: >>> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml >>> index 7503031d8f61..8eab6f60eb14 100644 >>> --- a/tools/ocaml/libs/xc/xenctrl.ml >>> +++ b/tools/ocaml/libs/xc/xenctr

Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-18 Thread Andrew Cooper
On 18/05/2022 10:51, Edwin Torok wrote: >> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml >> index 7503031d8f61..8eab6f60eb14 100644 >> --- a/tools/ocaml/libs/xc/xenctrl.ml >> +++ b/tools/ocaml/libs/xc/xenctrl.ml >> @@ -85,6 +85,7 @@ type domctl_create_config = >>

Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-18 Thread Edwin Torok
> On 17 May 2022, at 20:41, Andrew Cooper wrote: > > Sadly, cpupool IDs are chosen by the caller, not assigned sequentially, so > this does need to have a full 32 bits of range. > > Also leave a BUILD_BUG_ON() to catch more obvious ABI changes in the future. > > Fixes: 92ea9c54fc81 ("arm/dom0

Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-18 Thread Christian Lindig
Acked-by: Christian Lindig mailto:christian.lin...@citrix.com>> On 17 May 2022, at 20:41, Andrew Cooper mailto:andrew.coop...@citrix.com>> wrote: Sadly, cpupool IDs are chosen by the caller, not assigned sequentially, so this does need to have a full 32 bits of range. Also leave a BUILD_BUG_O

[PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id

2022-05-17 Thread Andrew Cooper
Sadly, cpupool IDs are chosen by the caller, not assigned sequentially, so this does need to have a full 32 bits of range. Also leave a BUILD_BUG_ON() to catch more obvious ABI changes in the future. Fixes: 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") Signed-off-by: Andrew Co