Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-16 Thread Jan Beulich
On 15.01.2024 15:50, Elias El Yandouzi wrote: > On 12/01/2024 07:47, Jan Beulich wrote: >> On 11.01.2024 19:25, Elias El Yandouzi wrote: >>> How would you proceed? Calling vmap() seems to be a bit overkill for >>> just a temporary mapping and I don't really want to rework this function >>> to use m

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-15 Thread Elias El Yandouzi
Hi, On 12/01/2024 07:47, Jan Beulich wrote: On 11.01.2024 19:25, Elias El Yandouzi wrote: On 11/01/2024 14:09, Jan Beulich wrote: What about maddr_to_virt()? For instance, in the function xen/arch/x86/dmi_scan.c:dmi_iterate(), we need to access a very low machine address which isn't in the dir

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-11 Thread Jan Beulich
On 11.01.2024 19:25, Elias El Yandouzi wrote: > > > On 11/01/2024 14:09, Jan Beulich wrote: >> On 11.01.2024 13:25, Julien Grall wrote: >>> Hi Jan, >>> >>> On 11/01/2024 11:53, Jan Beulich wrote: On 11.01.2024 11:47, Elias El Yandouzi wrote: > On 22/12/2022 13:24, Jan Beulich wrote:

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-11 Thread Elias El Yandouzi
On 11/01/2024 14:09, Jan Beulich wrote: On 11.01.2024 13:25, Julien Grall wrote: Hi Jan, On 11/01/2024 11:53, Jan Beulich wrote: On 11.01.2024 11:47, Elias El Yandouzi wrote: On 22/12/2022 13:24, Jan Beulich wrote: That said, I think this change comes too early in the series, or there is

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-11 Thread Jan Beulich
On 11.01.2024 13:25, Julien Grall wrote: > Hi Jan, > > On 11/01/2024 11:53, Jan Beulich wrote: >> On 11.01.2024 11:47, Elias El Yandouzi wrote: >>> On 22/12/2022 13:24, Jan Beulich wrote: That said, I think this change comes too early in the series, or there is something missing. >>> >>>

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-11 Thread Julien Grall
Hi Jan, On 11/01/2024 11:53, Jan Beulich wrote: On 11.01.2024 11:47, Elias El Yandouzi wrote: On 22/12/2022 13:24, Jan Beulich wrote: That said, I think this change comes too early in the series, or there is something missing. At first, I had the same feeling but looking at the rest of the s

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-11 Thread Jan Beulich
On 11.01.2024 11:47, Elias El Yandouzi wrote: > On 22/12/2022 13:24, Jan Beulich wrote: >> That said, I think this change comes too early in the series, or there is >> something missing. > > At first, I had the same feeling but looking at the rest of the series, > I can see that the option is ne

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-11 Thread Elias El Yandouzi
Hi, On 22/12/2022 13:24, Jan Beulich wrote: That said, I think this change comes too early in the series, or there is something missing. At first, I had the same feeling but looking at the rest of the series, I can see that the option is needed in follow-up patches. As said in reply to pa

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2023-01-23 Thread Julien Grall
Hi Stefano, On 23/01/2023 21:45, Stefano Stabellini wrote: diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 68adcac9fa8d..2366928d71aa 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -406,6 +406,11 @@ static inline void page_set_x

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2023-01-23 Thread Stefano Stabellini
On Fri, 16 Dec 2022, Julien Grall wrote: > From: Hongyan Xia > > Also add a helper function to retrieve it. Change arch_mfns_in_direct_map > to check this option before returning. > > This is added as a boot command line option, not a Kconfig to allow > the user to experiment the feature without

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2022-12-22 Thread Jan Beulich
On 16.12.2022 12:48, Julien Grall wrote: > From: Hongyan Xia > > Also add a helper function to retrieve it. Change arch_mfns_in_direct_map > to check this option before returning. I think the abstract parts of this want to be generic right away. I can't see why Arm would not suffer from the same

[PATCH 11/22] x86: add a boot option to enable and disable the direct map

2022-12-16 Thread Julien Grall
From: Hongyan Xia Also add a helper function to retrieve it. Change arch_mfns_in_direct_map to check this option before returning. This is added as a boot command line option, not a Kconfig to allow the user to experiment the feature without rebuild the hypervisor. Signed-off-by: Hongyan Xia S