Re: [PATCH 1/6] xen/hvm: Convert hap_capabilities into a bitfield

2024-02-20 Thread George Dunlap
On Wed, Feb 21, 2024 at 3:23 PM Jan Beulich wrote: > > On 21.02.2024 08:02, George Dunlap wrote: > > On Mon, Feb 19, 2024 at 9:36 PM Jan Beulich wrote: > >> On 06.02.2024 02:20, George Dunlap wrote: > >>> --- a/xen/arch/x86/hvm/vmx/vmcs.c > >>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c > >>> @@ -113,8 +1

Re: [PATCH 1/6] xen/hvm: Convert hap_capabilities into a bitfield

2024-02-20 Thread Jan Beulich
On 21.02.2024 08:02, George Dunlap wrote: > On Mon, Feb 19, 2024 at 9:36 PM Jan Beulich wrote: >> On 06.02.2024 02:20, George Dunlap wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmcs.c >>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c >>> @@ -113,8 +113,8 @@ static int cf_check parse_ept_param_runtime(const char >>

Re: [PATCH 1/6] xen/hvm: Convert hap_capabilities into a bitfield

2024-02-20 Thread George Dunlap
On Mon, Feb 19, 2024 at 9:36 PM Jan Beulich wrote: > > On 06.02.2024 02:20, George Dunlap wrote: > > hvm_function_table is an internal structure; rather than manually > > |-ing and &-ing bits, just make it a boolean bitfield and let the > > compiler do all the work. This makes everything easier t

Re: [PATCH 1/6] xen/hvm: Convert hap_capabilities into a bitfield

2024-02-19 Thread Jan Beulich
On 06.02.2024 02:20, George Dunlap wrote: > hvm_function_table is an internal structure; rather than manually > |-ing and &-ing bits, just make it a boolean bitfield and let the > compiler do all the work. This makes everything easier to read, and > presumably allows the compiler more flexibility

[PATCH 1/6] xen/hvm: Convert hap_capabilities into a bitfield

2024-02-05 Thread George Dunlap
hvm_function_table is an internal structure; rather than manually |-ing and &-ing bits, just make it a boolean bitfield and let the compiler do all the work. This makes everything easier to read, and presumably allows the compiler more flexibility in producing efficient code. No functional change