Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-21 Thread Andrew Cooper
On 21/02/2023 11:42 am, Xenia Ragiadakou wrote: > > On 2/21/23 13:12, Jan Beulich wrote: >> On 21.02.2023 08:45, Xenia Ragiadakou wrote: >>> Hi Andrew, >>> >>> On 2/21/23 00:12, Andrew Cooper wrote: On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: > Do not include the headers: >     xen/

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-21 Thread Xenia Ragiadakou
On 2/21/23 13:12, Jan Beulich wrote: On 21.02.2023 08:45, Xenia Ragiadakou wrote: Hi Andrew, On 2/21/23 00:12, Andrew Cooper wrote: On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-21 Thread Jan Beulich
On 21.02.2023 08:45, Xenia Ragiadakou wrote: > Hi Andrew, > > On 2/21/23 00:12, Andrew Cooper wrote: >> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>> Do not include the headers: >>>xen/irq.h >>>asm/hvm/svm/intr.h >>>asm/io.h >>>asm/mem_sharing.h >>>asm/regs.h >> >> Out of

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-20 Thread Xenia Ragiadakou
Hi Andrew, On 2/21/23 00:12, Andrew Cooper wrote: On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs.h Out of interest, how are you calculating these?  They're accurate as far as I can tell

Re: [PATCH 1/4] x86/svm: cleanup svm.c

2023-02-20 Thread Andrew Cooper
On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: > Do not include the headers: > xen/irq.h > asm/hvm/svm/intr.h > asm/io.h > asm/mem_sharing.h > asm/regs.h Out of interest, how are you calculating these?  They're accurate as far as I can tell. Looking at asm/hvm/svm/*, intr.h itself can b

[PATCH 1/4] x86/svm: cleanup svm.c

2023-02-17 Thread Xenia Ragiadakou
Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs.h because none of the declarations and macro definitions in them is used. Sort alphabetically the rest of the headers. Remove the forward declaration of svm_function_table and place start_svm() a