Re: [PATCH 1/4] build: work around bash issue

2020-08-06 Thread Andrew Cooper
On 06/08/2020 10:14, Jan Beulich wrote: > On 06.08.2020 11:07, Julien Grall wrote: >> On 06/08/2020 10:04, Jan Beulich wrote: >>> Older bash fails to honor "set -e" for certain built-in commands >> "Older" is pretty vague. May I ask the exact version you run into the issue? > If I knew in what vers

Re: [PATCH 1/4] build: work around bash issue

2020-08-06 Thread Julien Grall
On 06/08/2020 10:25, Jan Beulich wrote: On 06.08.2020 11:20, Julien Grall wrote: On 06/08/2020 10:14, Jan Beulich wrote: I've observed it with 3.2.57(2). Thank you. Please mention it in the commit message. Well, added. If I had seen any use of the precise version, I would have done so right

Re: [PATCH 1/4] build: work around bash issue

2020-08-06 Thread Jan Beulich
On 06.08.2020 11:20, Julien Grall wrote: > On 06/08/2020 10:14, Jan Beulich wrote: >> I've observed it with 3.2.57(2). > > Thank you. Please mention it in the commit message. Well, added. If I had seen any use of the precise version, I would have done so right away. Would you mind educating me ho

Re: [PATCH 1/4] build: work around bash issue

2020-08-06 Thread Julien Grall
On 06/08/2020 10:14, Jan Beulich wrote: On 06.08.2020 11:07, Julien Grall wrote: On 06/08/2020 10:04, Jan Beulich wrote: Older bash fails to honor "set -e" for certain built-in commands "Older" is pretty vague. May I ask the exact version you run into the issue? If I knew in what version

Re: [PATCH 1/4] build: work around bash issue

2020-08-06 Thread Jan Beulich
On 06.08.2020 11:07, Julien Grall wrote: > On 06/08/2020 10:04, Jan Beulich wrote: >> Older bash fails to honor "set -e" for certain built-in commands > > "Older" is pretty vague. May I ask the exact version you run into the issue? If I knew in what version the issue got fixed, I'd have specified

Re: [PATCH 1/4] build: work around bash issue

2020-08-06 Thread Julien Grall
Hi Jan, On 06/08/2020 10:04, Jan Beulich wrote: Older bash fails to honor "set -e" for certain built-in commands "Older" is pretty vague. May I ask the exact version you run into the issue? ("while" here), despite the command's status correctly bein non-zero. The subsequent objcopy invocatio

[PATCH 1/4] build: work around bash issue

2020-08-06 Thread Jan Beulich
Older bash fails to honor "set -e" for certain built-in commands ("while" here), despite the command's status correctly bein non-zero. The subsequent objcopy invocation now being separated by a semicolon results in no failure. Insert an explicit "exit" (replacing ; by && ought to be another possibl