Re: [PATCH 1/3] x86/mm: do not attempt to convert _PAGE_GNTTAB to a boolean

2020-05-05 Thread Jan Beulich
On 05.05.2020 16:11, Roger Pau Monné wrote: > On Tue, May 05, 2020 at 03:47:43PM +0200, Jan Beulich wrote: >> On 05.05.2020 11:24, Roger Pau Monne wrote: >>> Remove the conversion of _PAGE_GNTTAB to a boolean, since the and >>> operation performed afterwards will already return false if the value >

Re: [PATCH 1/3] x86/mm: do not attempt to convert _PAGE_GNTTAB to a boolean

2020-05-05 Thread Roger Pau Monné
On Tue, May 05, 2020 at 03:47:43PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 05.05.2020 11:24, Roger Pau Monne wrote: > > Clang 10 complains with: > > > > mm.c:1

Re: [PATCH 1/3] x86/mm: do not attempt to convert _PAGE_GNTTAB to a boolean

2020-05-05 Thread Jan Beulich
On 05.05.2020 11:24, Roger Pau Monne wrote: > Clang 10 complains with: > > mm.c:1239:10: error: converting the result of '<<' to a boolean always > evaluates to true > [-Werror,-Wtautological-constant-compare] > if ( _PAGE_GNTTAB && (l1e_get_flags(l1e) & _PAGE_GNTTAB) && > ^ >

[PATCH 1/3] x86/mm: do not attempt to convert _PAGE_GNTTAB to a boolean

2020-05-05 Thread Roger Pau Monne
Clang 10 complains with: mm.c:1239:10: error: converting the result of '<<' to a boolean always evaluates to true [-Werror,-Wtautological-constant-compare] if ( _PAGE_GNTTAB && (l1e_get_flags(l1e) & _PAGE_GNTTAB) && ^ xen/include/asm/x86_64/page.h:161:25: note: expanded from ma