Re: [PATCH 1/3] x86/acpi: Drop acpi_video_flags and use bootsym(video_flags) directly

2024-09-05 Thread Andrew Cooper
On 05/09/2024 4:05 pm, Alejandro Vallejo wrote: > On Thu Sep 5, 2024 at 2:06 PM BST, Andrew Cooper wrote: >> This removes a level of indirection, as well as removing a somewhat >> misleading >> name; the variable is really "S3 video quirks". > nit: Would it be beneficial to rename video_flags to s

Re: [PATCH 1/3] x86/acpi: Drop acpi_video_flags and use bootsym(video_flags) directly

2024-09-05 Thread Alejandro Vallejo
On Thu Sep 5, 2024 at 2:06 PM BST, Andrew Cooper wrote: > This removes a level of indirection, as well as removing a somewhat misleading > name; the variable is really "S3 video quirks". nit: Would it be beneficial to rename video_flags to s3_video_flags? > > More importantly however it makes it

Re: [PATCH 1/3] x86/acpi: Drop acpi_video_flags and use bootsym(video_flags) directly

2024-09-05 Thread Jan Beulich
On 05.09.2024 15:06, Andrew Cooper wrote: > This removes a level of indirection, as well as removing a somewhat misleading > name; the variable is really "S3 video quirks". > > More importantly however it makes it very clear that, right now, parsing the > cmdline and quirks depends on having alrea

[PATCH 1/3] x86/acpi: Drop acpi_video_flags and use bootsym(video_flags) directly

2024-09-05 Thread Andrew Cooper
This removes a level of indirection, as well as removing a somewhat misleading name; the variable is really "S3 video quirks". More importantly however it makes it very clear that, right now, parsing the cmdline and quirks depends on having already placed the trampoline; a dependency which is goin