Re: [PATCH 1/3] x86/HVM: fold hvm_io_assist() into its only caller

2020-07-15 Thread Jan Beulich
On 15.07.2020 14:40, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 15 July 2020 13:04 >> >> static bool hvm_wait_for_io(struct hvm_ioreq_vcpu *sv, ioreq_t *p) >> { >> unsigned int prev_state = STATE_IOREQ_NONE; >> +uint64_t data = ~0; >> >> -while ( sv->pending ) >> -{ >> +

RE: [PATCH 1/3] x86/HVM: fold hvm_io_assist() into its only caller

2020-07-15 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 15 July 2020 13:04 > To: xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; Roger Pau Monné > ; Wei Liu > ; Paul Durrant > Subject: [PATCH 1/3] x86/HVM: fold hvm_io_assist() into its only caller > > While

[PATCH 1/3] x86/HVM: fold hvm_io_assist() into its only caller

2020-07-15 Thread Jan Beulich
While there are two call sites, the function they're in can be slightly re-arranged such that the code sequence can be added at its bottom. Note that the function's only caller has already checked sv->pending, and that the prior while() loop was just a slightly more fancy if() (allowing an early br