Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-28 Thread Jan Beulich
On 27.03.2023 18:22, Juergen Gross wrote: > On 27.03.23 17:38, Jan Beulich wrote: >> On 27.03.2023 12:07, Juergen Gross wrote: >>> On 27.03.23 11:49, Jan Beulich wrote: On 27.03.2023 10:36, Juergen Gross wrote: > @@ -539,6 +553,13 @@ static int xenvif_tx_check_gop(struct xenvif_queue

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Juergen Gross
On 27.03.23 17:38, Jan Beulich wrote: On 27.03.2023 12:07, Juergen Gross wrote: On 27.03.23 11:49, Jan Beulich wrote: On 27.03.2023 10:36, Juergen Gross wrote: @@ -413,6 +418,13 @@ static void xenvif_get_requests(struct xenvif_queue *queue, cop->dest.u.gmfn = virt_to_gfn(skb->d

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Jan Beulich
On 27.03.2023 12:07, Juergen Gross wrote: > On 27.03.23 11:49, Jan Beulich wrote: >> On 27.03.2023 10:36, Juergen Gross wrote: >>> @@ -413,6 +418,13 @@ static void xenvif_get_requests(struct xenvif_queue >>> *queue, >>> cop->dest.u.gmfn = virt_to_gfn(skb->data + skb_headlen(skb) >>>

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Juergen Gross
On 27.03.23 11:49, Jan Beulich wrote: On 27.03.2023 10:36, Juergen Gross wrote: Fix xenvif_get_requests() not to do grant copy operations across local page boundaries. This requires to double the maximum number of copy operations per queue, as each copy could now be split into 2. Make sure that

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Jan Beulich
On 27.03.2023 10:36, Juergen Gross wrote: > Fix xenvif_get_requests() not to do grant copy operations across local > page boundaries. This requires to double the maximum number of copy > operations per queue, as each copy could now be split into 2. > > Make sure that struct xenvif_tx_cb doesn't gr

Re: [PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Paul Durrant
On 27/03/2023 09:36, Juergen Gross wrote: Fix xenvif_get_requests() not to do grant copy operations across local page boundaries. This requires to double the maximum number of copy operations per queue, as each copy could now be split into 2. Make sure that struct xenvif_tx_cb doesn't grow too l

[PATCH 1/2] xen/netback: don't do grant copy across page boundary

2023-03-27 Thread Juergen Gross
Fix xenvif_get_requests() not to do grant copy operations across local page boundaries. This requires to double the maximum number of copy operations per queue, as each copy could now be split into 2. Make sure that struct xenvif_tx_cb doesn't grow too large. Cc: sta...@vger.kernel.org Fixes: ad7