Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Marek Marczykowski-Górecki
On Tue, Jun 24, 2025 at 04:12:46PM +0100, Frediano Ziglio wrote: > On Tue, Jun 24, 2025 at 3:35 PM Marek Marczykowski-Górecki > wrote: > > > > On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote: > > > OT: the flow of read_file (specifically "what" handling) looks > > > weird... can I

Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Marek Marczykowski-Górecki
On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote: > OT: the flow of read_file (specifically "what" handling) looks > weird... can I change it? It tries to avoid duplication of PrintErr calls, while including what failed in the error message. Looks like somebody really wanted to avoi

Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Jan Beulich
On 24.06.2025 16:35, Marek Marczykowski-Górecki wrote: > On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote: >> OT: the flow of read_file (specifically "what" handling) looks >> weird... can I change it? > > It tries to avoid duplication of PrintErr calls, while including what > faile

Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Frediano Ziglio
On Tue, Jun 24, 2025 at 3:35 PM Marek Marczykowski-Górecki wrote: > > On Tue, Jun 24, 2025 at 03:05:25PM +0100, Frediano Ziglio wrote: > > OT: the flow of read_file (specifically "what" handling) looks > > weird... can I change it? > > It tries to avoid duplication of PrintErr calls, while includi

Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Frediano Ziglio
On Tue, Jun 24, 2025 at 1:38 PM Marek Marczykowski-Górecki wrote: > > On Tue, Jun 24, 2025 at 09:31:54AM +0100, Frediano Ziglio wrote: > > A boot loader can load files from outside ESP. > > In these cases device could be not provided or path could > > be something not supported. > > In these cases

Re: [PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Marek Marczykowski-Górecki
On Tue, Jun 24, 2025 at 09:31:54AM +0100, Frediano Ziglio wrote: > A boot loader can load files from outside ESP. > In these cases device could be not provided or path could > be something not supported. > In these cases allows to boot anyway, all information > could be provided using UKI or using

[PATCH 1/2] xen/efi: Handle cases where file didn't come from ESP

2025-06-24 Thread Frediano Ziglio
A boot loader can load files from outside ESP. In these cases device could be not provided or path could be something not supported. In these cases allows to boot anyway, all information could be provided using UKI or using other boot loader features. Signed-off-by: Frediano Ziglio --- xen/commo