Re: [PATCH 1/2] x86/vpic: rename irq to pin in vpic_ioport_write

2020-08-20 Thread Andrew Cooper
On 20/08/2020 16:34, Roger Pau Monne wrote: > The irq variable is wrongly named, as it's used to store the pin on > the 8259 chip, but not the global irq value. While renaming reduce > it's scope and make it unsigned. > > No functional change intended. > > Signed-off-by: Roger Pau Monné Acked-by:

[PATCH 1/2] x86/vpic: rename irq to pin in vpic_ioport_write

2020-08-20 Thread Roger Pau Monne
The irq variable is wrongly named, as it's used to store the pin on the 8259 chip, but not the global irq value. While renaming reduce it's scope and make it unsigned. No functional change intended. Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/vpic.c | 18 ++ 1 file chang