Re: [PATCH 1/2] include: don't use asm/page.h from common headers

2020-12-04 Thread Julien Grall
Hi Jan, On 03/12/2020 09:27, Jan Beulich wrote: On 02.12.2020 18:14, Julien Grall wrote: Hi Jan, On 02/12/2020 14:49, Jan Beulich wrote: Doing so limits what can be done in (in particular included by) this per- arch header. Abstract out page shift/size related #define-s, which is all the reps

Re: [PATCH 1/2] include: don't use asm/page.h from common headers

2020-12-03 Thread Andrew Cooper
On 03/12/2020 09:27, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-arm/page-shift.h >> The name of the file looks a bit odd given that *_BITS are also defined >> in it. So how about renaming to page-size.h? > I was initially meaning to use that name, but these headers > specifical

Re: [PATCH 1/2] include: don't use asm/page.h from common headers

2020-12-03 Thread Jan Beulich
On 02.12.2020 18:14, Julien Grall wrote: > Hi Jan, > > On 02/12/2020 14:49, Jan Beulich wrote: >> Doing so limits what can be done in (in particular included by) this per- >> arch header. Abstract out page shift/size related #define-s, which is all >> the repsecitve headers care about. Extend the

Re: [PATCH 1/2] include: don't use asm/page.h from common headers

2020-12-02 Thread Julien Grall
Hi Jan, On 02/12/2020 14:49, Jan Beulich wrote: Doing so limits what can be done in (in particular included by) this per- arch header. Abstract out page shift/size related #define-s, which is all the repsecitve headers care about. Extend the replacement / removal to s/repsecitve/respective/

[PATCH 1/2] include: don't use asm/page.h from common headers

2020-12-02 Thread Jan Beulich
Doing so limits what can be done in (in particular included by) this per- arch header. Abstract out page shift/size related #define-s, which is all the repsecitve headers care about. Extend the replacement / removal to some x86 headers as well; some others now need to include page.h (and they reall