RE: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Paul Durrant
gt; Stabellini' ; 'Anthony Perard' > ; xen- > de...@lists.xenproject.org > Subject: RE: [PATCH 1/2] Fix undefined behaviour > > > -Original Message- > > From: Artur Puzio > > Sent: 28 April 2020 10:41 > > To: p...@xen.org; 'Grzegorz Uri

RE: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Paul Durrant
lini' ; 'Anthony Perard' > ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH 1/2] Fix undefined behaviour > > On 28.04.2020 10:10, Paul Durrant wrote: > >> -Original Message- > >> From: Grzegorz Uriasz > >> Sent: 28 April 2020

Re: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Artur Puzio
.ski; j.nowa...@student.uw.edu.pl; Stefano Stabellini >> ; Anthony >> Perard ; Paul Durrant ; >> xen-devel@lists.xenproject.org >> Subject: [PATCH 1/2] Fix undefined behaviour >> >> Signed-off-by: Grzegorz Uriasz > I think we need more of a commit comment fo

Re: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Peter Maydell
On Tue, 28 Apr 2020 at 08:50, Grzegorz Uriasz wrote: > > Signed-off-by: Grzegorz Uriasz > --- > hw/xen/xen_pt_load_rom.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) The subject doesn't match the patch contents and there is no long-form part of the commit message explaini

RE: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Paul Durrant
> Perard ; Paul Durrant ; > xen-devel@lists.xenproject.org > Subject: [PATCH 1/2] Fix undefined behaviour > > Signed-off-by: Grzegorz Uriasz I think we need more of a commit comment for both this and patch #2 to explain why you are making the changes. Paul

[PATCH 1/2] Fix undefined behaviour

2020-04-27 Thread Grzegorz Uriasz
Signed-off-by: Grzegorz Uriasz --- hw/xen/xen_pt_load_rom.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index a50a80837e..9f100dc159 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -38,