Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Stefano Stabellini
On Tue, 22 Jul 2025, Jan Beulich wrote: > On 22.07.2025 15:31, Alejandro Vallejo wrote: > > On Tue Jul 22, 2025 at 2:57 PM CEST, Jan Beulich wrote: > >> On 22.07.2025 14:37, Alejandro Vallejo wrote: > >>> On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote: > On 22.07.2025 13:59, Alejandro

Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Jan Beulich
On 22.07.2025 15:31, Alejandro Vallejo wrote: > On Tue Jul 22, 2025 at 2:57 PM CEST, Jan Beulich wrote: >> On 22.07.2025 14:37, Alejandro Vallejo wrote: >>> On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote: On 22.07.2025 13:59, Alejandro Vallejo wrote: > Reduce the scope of every var

Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Alejandro Vallejo
On Tue Jul 22, 2025 at 2:57 PM CEST, Jan Beulich wrote: > On 22.07.2025 14:37, Alejandro Vallejo wrote: >> On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote: >>> On 22.07.2025 13:59, Alejandro Vallejo wrote: Reduce the scope of every variable so they are reinitialised. "iommu", for i

Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Jan Beulich
On 22.07.2025 14:37, Alejandro Vallejo wrote: > On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote: >> On 22.07.2025 13:59, Alejandro Vallejo wrote: >>> Reduce the scope of every variable so they are reinitialised. "iommu", >>> for instance, isn't being cleared, so the wrong flags may make it t

Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Alejandro Vallejo
On Tue Jul 22, 2025 at 2:18 PM CEST, Jan Beulich wrote: > On 22.07.2025 13:59, Alejandro Vallejo wrote: >> Reduce the scope of every variable so they are reinitialised. "iommu", >> for instance, isn't being cleared, so the wrong flags may make it to >> domains that should not have them. > > Yet "fo

Re: [PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Jan Beulich
On 22.07.2025 13:59, Alejandro Vallejo wrote: > Reduce the scope of every variable so they are reinitialised. "iommu", > for instance, isn't being cleared, so the wrong flags may make it to > domains that should not have them. Yet "for instance" isn't quite right, is it? "iommu" is the only one wh

[PATCH 09/10] dom0less: Reinitialise all variables on each loop iteration

2025-07-22 Thread Alejandro Vallejo
Reduce the scope of every variable so they are reinitialised. "iommu", for instance, isn't being cleared, so the wrong flags may make it to domains that should not have them. Fixes: 1d2b4f3049fd("xen/arm, doc: Add a DT property to specify...") Signed-off-by: Alejandro Vallejo --- This is implicit