Re: [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-06-18 Thread George Dunlap
> On Jun 18, 2021, at 4:17 PM, Nick Rosbrook wrote: > > On Fri, Jun 18, 2021 at 01:17:07PM +, George Dunlap wrote: >> Also, is ‘xenlight’ informative enough? I haven’t looked at the other >> “context” strings; would “go-xenlight” or something be better? >> > > I believe libxl uses "libx

Re: [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-06-18 Thread George Dunlap
> On Jun 18, 2021, at 4:26 PM, Nick Rosbrook wrote: > > On Fri, Jun 18, 2021 at 01:21:40PM +, George Dunlap wrote: >> >> >>> On Jun 18, 2021, at 2:17 PM, George Dunlap wrote: >>> >>> >>> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: Add some logging methods to Con

Re: [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-06-18 Thread Nick Rosbrook
On Fri, Jun 18, 2021 at 01:21:40PM +, George Dunlap wrote: > > > > On Jun 18, 2021, at 2:17 PM, George Dunlap wrote: > > > > > > > >> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > >> > >> Add some logging methods to Context to provide easy use of the > >> Contenxt's xentoollog_log

Re: [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-06-18 Thread Nick Rosbrook
On Fri, Jun 18, 2021 at 01:17:07PM +, George Dunlap wrote: > > > > On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > > > > Add some logging methods to Context to provide easy use of the > > Contenxt's xentoollog_logger. These are not exported, but the LogLevel > > type is so that a later

Re: [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-06-18 Thread George Dunlap
> On Jun 18, 2021, at 2:17 PM, George Dunlap wrote: > > > >> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: >> >> Add some logging methods to Context to provide easy use of the >> Contenxt's xentoollog_logger. These are not exported, but the LogLevel >> type is so that a later commit can

Re: [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-06-18 Thread George Dunlap
> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > > Add some logging methods to Context to provide easy use of the > Contenxt's xentoollog_logger. These are not exported, but the LogLevel > type is so that a later commit can allow the Context's log level to be > configurable. > > Becuase c

[RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-05-24 Thread Nick Rosbrook
Add some logging methods to Context to provide easy use of the Contenxt's xentoollog_logger. These are not exported, but the LogLevel type is so that a later commit can allow the Context's log level to be configurable. Becuase cgo does not support calling C functions with variable arguments, e.g.

[PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight

2021-04-28 Thread Nick Rosbrook
Add some logging methods to Context to provide easy use of the Contenxt's xentoollog_logger. These are not exported, but the LogLevel type is so that a later commit can allow the Context's log level to be configurable. Becuase cgo does not support calling C functions with variable arguments, e.g.